2022-09-19 21:02:20

by Marijn Suijten

[permalink] [raw]
Subject: [PATCH v3 0/5] Add Qcom PM6125 PMIC, and use in Sony Xperia Seine PDX201

This series adds initial support for the PM6125 PMIC, and its power key
handling and thermal monitoring capabilities are configured for Sony's
PDX201 (Xperia 10II).

One patch for pm660 is included to fix a node address mismatch with its
reg field.

Changes since v2:
- Rebased on v6.0-rc6 to drop dependent DT patches;
- Dropped iio patch which has already been picked into Jonathan's tree;
- Added qcom,pm6125 compatible in new yaml-ified SPMI-PMIC dt-bindings.

v2: https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u

Changes since v1:
- Dropped both pinctrl patches that have already been applied;
- Add -us suffix to qcom,hw-settle-time properties on ADC TM5 nodes
(this suffix is not present on regular ADC5/VADC nodes);
- Add -state suffix to pm6125_gpio pinctrl nodes;
- Use PMIC_GPIO_FUNC_NORMAL instead of the string-literal "normal";
- Removed #address-cells and #size-cells from empty pmic@1 node;
- Removed ADC5_AMUX_THM3 / ADC5_GPIO2_100K_PU channels from the ADC5
patch, these are unused on my board and hence untested.

v1: https://lore.kernel.org/phone-devel/[email protected]/T/#u

Marijn Suijten (5):
dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible
arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name
arm64: dts: qcom: Add PM6125 PMIC
arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON
arm64: dts: qcom: sm6125-seine: Configure additional trinket
thermistors

.../bindings/mfd/qcom,spmi-pmic.yaml | 1 +
arch/arm64/boot/dts/qcom/pm6125.dtsi | 154 +++++++++++++++++
arch/arm64/boot/dts/qcom/pm660.dtsi | 2 +-
.../qcom/sm6125-sony-xperia-seine-pdx201.dts | 162 +++++++++++++++++-
4 files changed, 317 insertions(+), 2 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/pm6125.dtsi

--
2.37.3


2022-09-19 21:03:04

by Marijn Suijten

[permalink] [raw]
Subject: [PATCH v3 1/5] dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible

Document support for the pm6125, typically paired with the sm6125 SoC.

Signed-off-by: Marijn Suijten <[email protected]>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545..a6ee8c7f7738 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -35,6 +35,7 @@ properties:
- enum:
- qcom,pm660
- qcom,pm660l
+ - qcom,pm6125
- qcom,pm6150
- qcom,pm6150l
- qcom,pm6350
--
2.37.3

2022-09-19 21:06:16

by Marijn Suijten

[permalink] [raw]
Subject: Re: [PATCH v3 0/5] Add Qcom PM6125 PMIC, and use in Sony Xperia Seine PDX201

On 2022-09-19 22:48:21, Marijn Suijten wrote:
> This series adds initial support for the PM6125 PMIC, and its power key
> handling and thermal monitoring capabilities are configured for Sony's
> PDX201 (Xperia 10II).
>
> One patch for pm660 is included to fix a node address mismatch with its
> reg field.
>
> Changes since v2:
> - Rebased on v6.0-rc6 to drop dependent DT patches;
> - Dropped iio patch which has already been picked into Jonathan's tree;
> - Added qcom,pm6125 compatible in new yaml-ified SPMI-PMIC dt-bindings.

And

- Renamed `pm6125_gpio: gpios@c000` node to `gpio`;

of course, as requested by Krzysztof.

- Marijn

>
> v2: https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u
>
> Changes since v1:
> - Dropped both pinctrl patches that have already been applied;
> - Add -us suffix to qcom,hw-settle-time properties on ADC TM5 nodes
> (this suffix is not present on regular ADC5/VADC nodes);
> - Add -state suffix to pm6125_gpio pinctrl nodes;
> - Use PMIC_GPIO_FUNC_NORMAL instead of the string-literal "normal";
> - Removed #address-cells and #size-cells from empty pmic@1 node;
> - Removed ADC5_AMUX_THM3 / ADC5_GPIO2_100K_PU channels from the ADC5
> patch, these are unused on my board and hence untested.
>
> v1: https://lore.kernel.org/phone-devel/[email protected]/T/#u
>
> Marijn Suijten (5):
> dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible
> arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name
> arm64: dts: qcom: Add PM6125 PMIC
> arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON
> arm64: dts: qcom: sm6125-seine: Configure additional trinket
> thermistors
>
> .../bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> arch/arm64/boot/dts/qcom/pm6125.dtsi | 154 +++++++++++++++++
> arch/arm64/boot/dts/qcom/pm660.dtsi | 2 +-
> .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 162 +++++++++++++++++-
> 4 files changed, 317 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/pm6125.dtsi
>
> --
> 2.37.3
>

2022-09-20 08:42:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/5] dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible

On 19/09/2022 22:48, Marijn Suijten wrote:
> Document support for the pm6125, typically paired with the sm6125 SoC.
>
> Signed-off-by: Marijn Suijten <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-09-26 08:07:20

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v3 1/5] dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible

On Mon, 19 Sep 2022, Marijn Suijten wrote:

> Document support for the pm6125, typically paired with the sm6125 SoC.
>
> Signed-off-by: Marijn Suijten <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)

Doesn't apply cleanly. Please rebase.

> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 65cbc6dee545..a6ee8c7f7738 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -35,6 +35,7 @@ properties:
> - enum:
> - qcom,pm660
> - qcom,pm660l
> + - qcom,pm6125
> - qcom,pm6150
> - qcom,pm6150l
> - qcom,pm6350

--
Lee Jones [李琼斯]