2022-09-22 11:06:27

by kernel test robot

[permalink] [raw]
Subject: drivers/pci/pci.c:4195 pci_pio_to_address() warn: always true condition '(pio >= (0 - 0)) => (0-u32max >= 0)'

Hi Stafford,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dc164f4fb00a0abebdfff132f8bc7291a28f5401
commit: ded2ee36313c941f1a12b6f85cde295b575264ae openrisc: Add pci bus support
date: 8 weeks ago
config: openrisc-randconfig-m031-20220921 (https://download.01.org/0day-ci/archive/20220922/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>

smatch warnings:
drivers/pci/pci.c:4195 pci_pio_to_address() warn: always true condition '(pio >= (0 - 0)) => (0-u32max >= 0)'

vim +4195 drivers/pci/pci.c

c5076cfe768998 Tomasz Nowicki 2016-05-11 4189
c5076cfe768998 Tomasz Nowicki 2016-05-11 4190 phys_addr_t pci_pio_to_address(unsigned long pio)
c5076cfe768998 Tomasz Nowicki 2016-05-11 4191 {
c5076cfe768998 Tomasz Nowicki 2016-05-11 4192 phys_addr_t address = (phys_addr_t)OF_BAD_ADDR;
c5076cfe768998 Tomasz Nowicki 2016-05-11 4193
c5076cfe768998 Tomasz Nowicki 2016-05-11 4194 #ifdef PCI_IOBASE
5745392e0c2b78 Zhichang Yuan 2018-03-15 @4195 if (pio >= MMIO_UPPER_LIMIT)
c5076cfe768998 Tomasz Nowicki 2016-05-11 4196 return address;
c5076cfe768998 Tomasz Nowicki 2016-05-11 4197
5745392e0c2b78 Zhichang Yuan 2018-03-15 4198 address = logic_pio_to_hwaddr(pio);
c5076cfe768998 Tomasz Nowicki 2016-05-11 4199 #endif
c5076cfe768998 Tomasz Nowicki 2016-05-11 4200
c5076cfe768998 Tomasz Nowicki 2016-05-11 4201 return address;
c5076cfe768998 Tomasz Nowicki 2016-05-11 4202 }
9cc742078c9a90 Jianjun Wang 2021-04-20 4203 EXPORT_SYMBOL_GPL(pci_pio_to_address);
c5076cfe768998 Tomasz Nowicki 2016-05-11 4204

:::::: The code at line 4195 was first introduced by commit
:::::: 5745392e0c2b78e0d73203281d5c42cbd6993194 PCI: Apply the new generic I/O management on PCI IO hosts

:::::: TO: Zhichang Yuan <[email protected]>
:::::: CC: Bjorn Helgaas <[email protected]>

--
0-DAY CI Kernel Test Service
https://01.org/lkp