On 23/09/2022 11:42, Sheng-Liang Pan wrote:
> evoker will have WIFI/LTE SKU, separete it for each different setting.
>
> Signed-off-by: Sheng-Liang Pan <[email protected]>
> ---
>
> Changes in v3:
> - none
Don't sent the same version. Either fix what I asked for or keep
discussing the topic.
Ignoring comments will not get the patch merged.
Best regards,
Krzysztof
Hi,
On Fri, Sep 23, 2022 at 5:15 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 23/09/2022 11:42, Sheng-Liang Pan wrote:
> > evoker will have WIFI/LTE SKU, separete it for each different setting.
> >
> > Signed-off-by: Sheng-Liang Pan <[email protected]>
> > ---
> >
> > Changes in v3:
> > - none
>
> Don't sent the same version. Either fix what I asked for or keep
> discussing the topic.
>
> Ignoring comments will not get the patch merged.
I agree with Krzysztof here. I can't see any difference between v2 and
v3, so I assume that you meant to fix his comment (spell "separete"
correctly in the commit message _and_ ${SUBJECT}) but somehow did
something wrong when sending v3.
In any case, other than the typo this looks fine to me. Feel free to
add my Reviewed-by when the typo is fixed.
-Doug