2022-09-23 18:01:40

by Andy Shevchenko

Subject: [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header

With compile testing on non-OMAP platforms compiler might be not happy:

In function ‘twl4030_sih_setup’:
error: implicit declaration of function ‘dev_err’ [-Werror=implicit-function-declaration]
error: implicit declaration of function ‘dev_info’ [-Werror=implicit-function-declaration]
In function ‘twl4030_init_irq’:
error: invalid use of undefined type ‘struct device’

Add missed header.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/twl4030-irq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 4f576f0160a9..87496c1cb8bc 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -14,6 +14,7 @@
* by syed khasim <[email protected]>
*/

+#include <linux/device.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
--
2.35.1

2022-09-26 07:59:25

by Lee Jones

Subject: Re: [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header

On Fri, 23 Sep 2022, Andy Shevchenko wrote:

> With compile testing on non-OMAP platforms compiler might be not happy:
>
> In function ‘twl4030_sih_setup’:
> error: implicit declaration of function ‘dev_err’ [-Werror=implicit-function-declaration]
> error: implicit declaration of function ‘dev_info’ [-Werror=implicit-function-declaration]
> In function ‘twl4030_init_irq’:
> error: invalid use of undefined type ‘struct device’
>
> Add missed header.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]