2022-10-14 21:00:52

by Masahiro Yamada

Subject: [PATCH] kbuild: fix single directory build

Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.

KBUILD_MODULES _is_ needed for single builds.

Otherwise, "make foo/bar/baz/" does not build module objects at all.

Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
Reported-by: David Sterba <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
---

Makefile | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index 85a63a1d29b3..48a005fc69ca 100644
--- a/Makefile
+++ b/Makefile
@@ -1978,6 +1978,8 @@ endif

single-goals := $(addprefix $(build-dir)/, $(single-no-ko))

+KBUILD_MODULES := 1
+
endif

# Preset locale variables to speed up the build process. Limit locale
--
2.34.1

2022-10-14 21:28:15

by David Sterba

Subject: Re: [PATCH] kbuild: fix single directory build

On Sat, Oct 15, 2022 at 05:18:11AM +0900, Masahiro Yamada wrote:
> Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.
>
> KBUILD_MODULES _is_ needed for single builds.
>
> Otherwise, "make foo/bar/baz/" does not build module objects at all.
>
> Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
> Reported-by: David Sterba <[email protected]>
> Signed-off-by: Masahiro Yamada <[email protected]>

Now it works, thanks.

Tested-by: David Sterba <[email protected]>