2022-10-17 12:01:16

by Patrick Delaunay

Subject: [PATCH] ARM: dts: stm32mp13: fix compatible for BSEC

Use the new compatible for stm32mp13 support.

Signed-off-by: Patrick Delaunay <[email protected]>
---
This device tree modification depends on the binding modification
introduced by the patch:

dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/

arch/arm/boot/dts/stm32mp131.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
index dd35a607073d..89a027f894f9 100644
--- a/arch/arm/boot/dts/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/stm32mp131.dtsi
@@ -398,7 +398,7 @@ rtc: rtc@5c004000 {
};

bsec: efuse@5c005000 {
- compatible = "st,stm32mp15-bsec";
+ compatible = "st,stm32mp13-bsec";
reg = <0x5c005000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
--
2.25.1

2022-10-18 02:44:42

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: dts: stm32mp13: fix compatible for BSEC

On 17/10/2022 07:44, Patrick Delaunay wrote:
> Use the new compatible for stm32mp13 support.
>
> Signed-off-by: Patrick Delaunay <[email protected]>
> ---
> This device tree modification depends on the binding modification
> introduced by the patch:
>
> dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/

This breaks users of DTS. The patch above did not describe devices as
compatible and that's the problem sending patches separately, without
context.

You need to keep compatible.

Best regards,
Krzysztof

2022-10-27 15:09:09

by Patrick Delaunay

Subject: Re: [PATCH] ARM: dts: stm32mp13: fix compatible for BSEC

Hi,

On 10/18/22 03:55, Krzysztof Kozlowski wrote:
> On 17/10/2022 07:44, Patrick Delaunay wrote:
>> Use the new compatible for stm32mp13 support.
>>
>> Signed-off-by: Patrick Delaunay <[email protected]>
>> ---
>> This device tree modification depends on the binding modification
>> introduced by the patch:
>>
>> dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
>> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/
> This breaks users of DTS. The patch above did not describe devices as
> compatible and that's the problem sending patches separately, without
> context.
>
> You need to keep compatible.
>
> Best regards,
> Krzysztof

I will sent a V2 patch in a serie with binding change, driver updates
and explanations.

Regards

Patrick