2022-10-18 08:09:58

by Xuezhi Zhang

Subject: [PATCH] fbdev: gbefb: convert sysfs snprintf to sysfs_emit

From: Xuezhi Zhang <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst
and show() should only use sysfs_emit() or sysfs_emit_at()
when formatting the value to be returned to user space.

Signed-off-by: Xuezhi Zhang <[email protected]>
---
drivers/video/fbdev/gbefb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
index 1582c718329c..000b4aa44241 100644
--- a/drivers/video/fbdev/gbefb.c
+++ b/drivers/video/fbdev/gbefb.c
@@ -1060,14 +1060,14 @@ static const struct fb_ops gbefb_ops = {

static ssize_t gbefb_show_memsize(struct device *dev, struct device_attribute *attr, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%u\n", gbe_mem_size);
+ return sysfs_emit(buf, "%u\n", gbe_mem_size);
}

static DEVICE_ATTR(size, S_IRUGO, gbefb_show_memsize, NULL);

static ssize_t gbefb_show_rev(struct device *device, struct device_attribute *attr, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%d\n", gbe_revision);
+ return sysfs_emit(buf, "%d\n", gbe_revision);
}

static DEVICE_ATTR(revision, S_IRUGO, gbefb_show_rev, NULL);
--
2.25.1

2022-10-18 09:24:25

by Helge Deller

Subject: Re: [PATCH] fbdev: gbefb: convert sysfs snprintf to sysfs_emit

On 10/18/22 09:51, Xuezhi Zhang wrote:
> From: Xuezhi Zhang <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Xuezhi Zhang <[email protected]>

applied.
Thanks!
Helge

> ---
> drivers/video/fbdev/gbefb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 1582c718329c..000b4aa44241 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -1060,14 +1060,14 @@ static const struct fb_ops gbefb_ops = {
>
> static ssize_t gbefb_show_memsize(struct device *dev, struct device_attribute *attr, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%u\n", gbe_mem_size);
> + return sysfs_emit(buf, "%u\n", gbe_mem_size);
> }
>
> static DEVICE_ATTR(size, S_IRUGO, gbefb_show_memsize, NULL);
>
> static ssize_t gbefb_show_rev(struct device *device, struct device_attribute *attr, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%d\n", gbe_revision);
> + return sysfs_emit(buf, "%d\n", gbe_revision);
> }
>
> static DEVICE_ATTR(revision, S_IRUGO, gbefb_show_rev, NULL);