2022-10-19 09:46:04

by Ilpo Järvinen

Subject: [PATCH 22/44] serial: meson: Use uart_xmit_advance()

Take advantage of the new uart_xmit_advance() helper.

Signed-off-by: Ilpo Järvinen <[email protected]>
---
drivers/tty/serial/meson_uart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 056243c12836..74110017988a 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -162,8 +162,7 @@ static void meson_uart_start_tx(struct uart_port *port)

ch = xmit->buf[xmit->tail];
writel(ch, port->membase + AML_UART_WFIFO);
- xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- port->icount.tx++;
+ uart_xmit_advance(port, 1);
}

if (!uart_circ_empty(xmit)) {
--
2.30.2

2022-10-19 10:33:26

by Neil Armstrong

Subject: Re: [PATCH 22/44] serial: meson: Use uart_xmit_advance()

On 19/10/2022 11:11, Ilpo Järvinen wrote:
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <[email protected]>
> ---
> drivers/tty/serial/meson_uart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 056243c12836..74110017988a 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -162,8 +162,7 @@ static void meson_uart_start_tx(struct uart_port *port)
>
> ch = xmit->buf[xmit->tail];
> writel(ch, port->membase + AML_UART_WFIFO);
> - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
> - port->icount.tx++;
> + uart_xmit_advance(port, 1);
> }
>
> if (!uart_circ_empty(xmit)) {


Acked-by: Neil Armstrong <[email protected]>

2022-10-19 21:13:24

by Martin Blumenstingl

Subject: Re: [PATCH 22/44] serial: meson: Use uart_xmit_advance()

On Wed, Oct 19, 2022 at 11:13 AM Ilpo Järvinen
<[email protected]> wrote:
>
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <[email protected]>
Acked-by: Martin Blumenstingl <[email protected]>

That helper is a welcome improvement in my opinion. Thanks for working on this!