2022-10-20 08:53:49

by Emil Renner Berthing

Subject: [PATCH v1] riscv: dts: icicle: Add GPIO controlled LEDs

This adds the 4 GPIO controlled LEDs to the Microchip PolarFire-SoC
Icicle Kit device tree. The schematic doesn't specify any special
function for the LEDs, so they're added here without any default
triggers and named led1, led2, led3 and led4 just like in the schematic.

Signed-off-by: Emil Renner Berthing <[email protected]>
---
.../boot/dts/microchip/mpfs-icicle-kit.dts | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)

diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
index ec7b7c2a3ce2..11ba4417f11a 100644
--- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
+++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
@@ -5,6 +5,8 @@

#include "mpfs.dtsi"
#include "mpfs-icicle-kit-fabric.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>

/* Clock frequency (in Hz) of the rtcclk */
#define RTCCLK_FREQ 1000000
@@ -31,6 +33,34 @@ cpus {
timebase-frequency = <RTCCLK_FREQ>;
};

+ leds {
+ compatible = "gpio-leds";
+
+ led-1 {
+ gpios = <&gpio2 16 GPIO_ACTIVE_HIGH>;
+ color = <LED_COLOR_ID_RED>;
+ label = "led1";
+ };
+
+ led-2 {
+ gpios = <&gpio2 17 GPIO_ACTIVE_HIGH>;
+ color = <LED_COLOR_ID_RED>;
+ label = "led2";
+ };
+
+ led-3 {
+ gpios = <&gpio2 18 GPIO_ACTIVE_HIGH>;
+ color = <LED_COLOR_ID_AMBER>;
+ label = "led3";
+ };
+
+ led-4 {
+ gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+ color = <LED_COLOR_ID_AMBER>;
+ label = "led4";
+ };
+ };
+
ddrc_cache_lo: memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0x0 0x40000000>;
--
2.37.2

2022-10-22 12:47:43

by Conor Dooley

Subject: Re: [PATCH v1] riscv: dts: icicle: Add GPIO controlled LEDs

On Thu, Oct 20, 2022 at 10:38:54AM +0200, Emil Renner Berthing wrote:
> This adds the 4 GPIO controlled LEDs to the Microchip PolarFire-SoC
> Icicle Kit device tree. The schematic doesn't specify any special
> function for the LEDs, so they're added here without any default
> triggers and named led1, led2, led3 and led4 just like in the schematic.
>
> Signed-off-by: Emil Renner Berthing <[email protected]>

Hey Emil,

I applied this with a a minor modification to the subject & a
s/This adds/Add/. Messing w/ my setup so no b4-ty mail, but it should be
here:
https://git.kernel.org/conor/c/0d814000ad3589bf4f69c9cb25a3b77bbd55ffec

Thanks,
Conor.

> ---
> .../boot/dts/microchip/mpfs-icicle-kit.dts | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> index ec7b7c2a3ce2..11ba4417f11a 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> @@ -5,6 +5,8 @@
>
> #include "mpfs.dtsi"
> #include "mpfs-icicle-kit-fabric.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>
> /* Clock frequency (in Hz) of the rtcclk */
> #define RTCCLK_FREQ 1000000
> @@ -31,6 +33,34 @@ cpus {
> timebase-frequency = <RTCCLK_FREQ>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + led-1 {
> + gpios = <&gpio2 16 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_RED>;
> + label = "led1";
> + };
> +
> + led-2 {
> + gpios = <&gpio2 17 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_RED>;
> + label = "led2";
> + };
> +
> + led-3 {
> + gpios = <&gpio2 18 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_AMBER>;
> + label = "led3";
> + };
> +
> + led-4 {
> + gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_AMBER>;
> + label = "led4";
> + };
> + };
> +
> ddrc_cache_lo: memory@80000000 {
> device_type = "memory";
> reg = <0x0 0x80000000 0x0 0x40000000>;
> --
> 2.37.2
>