2022-10-27 06:29:41

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH 2/2] btrfs: Fix kernel-doc

No functional modification involved.

fs/btrfs/ordered-data.c:169: warning: expecting prototype for Add an ordered extent to the per(). Prototype was for btrfs_add_ordered_extent() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2603
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/btrfs/ordered-data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
index 1cbaacdc50da..461ecbe75e0f 100644
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -145,7 +145,7 @@ static inline struct rb_node *tree_search(struct btrfs_ordered_inode_tree *tree,
}

/**
- * Add an ordered extent to the per-inode tree.
+ * btrfs_add_ordered_extent - Add an ordered extent to the per-inode tree.
*
* @inode: Inode that this extent is for.
* @file_offset: Logical offset in file where the extent starts.
--
2.20.1.7.g153144c



2022-10-27 06:36:49

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH 1/2] btrfs: Fix kernel-doc

No functional modification involved.

fs/btrfs/ioctl.c:4358: warning: expecting prototype for Try to acquire fs_info:(). Prototype was for btrfs_try_lock_balance() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2604
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/btrfs/ioctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index ab847c4ffede..718f9aa3234b 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -4344,8 +4344,8 @@ void btrfs_update_ioctl_balance_args(struct btrfs_fs_info *fs_info,
}

/**
- * Try to acquire fs_info::balance_mutex as well as set BTRFS_EXLCOP_BALANCE as
- * required.
+ * btrfs_try_lock_balance - Try to acquire fs_info::balance_mutex as well as set
+ * BTRFS_EXLCOP_BALANCE as required.
*
* @fs_info: the filesystem
* @excl_acquired: ptr to boolean value which is set to false in case balance
--
2.20.1.7.g153144c


2022-10-27 13:09:46

by David Sterba

[permalink] [raw]
Subject: Re: [PATCH 2/2] btrfs: Fix kernel-doc

On Thu, Oct 27, 2022 at 02:20:13PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> fs/btrfs/ordered-data.c:169: warning: expecting prototype for Add an ordered extent to the per(). Prototype was for btrfs_add_ordered_extent() instead.

Thanks, I've sent patch that fixes all the kdoc formatting so we don't
get any more warnings.