2022-11-25 12:25:42

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH 18/24] drm/vc4: crtc: Introduce a lower-level crtc init helper

On 11/23/22 16:26, Maxime Ripard wrote:
> The current vc4_crtc_init() helper assumes that we will be using
> hardware planes and calls vc4_plane_init().
> While it's a reasonable assumption, we'll want to mock the plane and
> thus provide our own. Let's create a helper that will take the plane as
> an argument.
> Signed-off-by: Maxime Ripard <[email protected]>
> ---

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat