2022-11-25 12:26:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433

Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Cc: Sriranjani P <[email protected]>
Cc: Chanho Park <[email protected]>
Cc: Sam Protsenko <[email protected]>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index bd6a354b9cb5..6976e45aa769 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1118,22 +1118,26 @@ hdmiphy: [email protected] {
};

syscon_disp: [email protected] {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-disp-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x13b80000 0x1010>;
};

syscon_cam0: [email protected] {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-cam0-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x120f0000 0x1020>;
};

syscon_cam1: [email protected] {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-cam1-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x145f0000 0x1038>;
};

syscon_fsys: [email protected] {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-fsys-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x156f0000 0x1044>;
};

--
2.34.1


2022-11-25 12:28:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Cc: Sriranjani P <[email protected]>
Cc: Chanho Park <[email protected]>
Cc: Sam Protsenko <[email protected]>
---
.../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 68064a5e339c..42357466005e 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,10 +17,21 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- const: syscon
+ - items:
+ - enum:
+ - samsung,exynos5433-cam0-sysreg
+ - samsung,exynos5433-cam1-sysreg
+ - samsung,exynos5433-disp-sysreg
+ - samsung,exynos5433-fsys-sysreg
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ - items:
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ deprecated: true

reg:
maxItems: 1
--
2.34.1

2022-11-25 15:04:08

by Sam Protsenko

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Cc: Sriranjani P <[email protected]>
> Cc: Chanho Park <[email protected]>
> Cc: Sam Protsenko <[email protected]>
> ---

Hi Krzysztof,

Just curious: what is the rationale for adding those more specific
sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
pretty much the same register layout.

Other than that:

Reviewed-by: Sam Protsenko <[email protected]>

> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
>

2022-11-25 15:08:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

On 25/11/2022 15:22, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>> for them.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
>>
>> Cc: Sriranjani P <[email protected]>
>> Cc: Chanho Park <[email protected]>
>> Cc: Sam Protsenko <[email protected]>
>> ---
>
> Hi Krzysztof,
>
> Just curious: what is the rationale for adding those more specific
> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> pretty much the same register layout.
>

On Exynos5433 all these blocks have different registers. Are you saying
that Exynos850 has four (or more) sysregs which are exactly the same?
Same registers? Why would they duplicate it?

Best regards,
Krzysztof

2022-11-25 15:22:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

On 25/11/2022 15:57, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>> <[email protected]> wrote:
>>>>
>>>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>>>> for them.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>>>
>>>> ---
>>>>
>>>> Cc: Sriranjani P <[email protected]>
>>>> Cc: Chanho Park <[email protected]>
>>>> Cc: Sam Protsenko <[email protected]>
>>>> ---
>>>
>>> Hi Krzysztof,
>>>
>>> Just curious: what is the rationale for adding those more specific
>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>> pretty much the same register layout.
>>>
>>
>> On Exynos5433 all these blocks have different registers. Are you saying
>> that Exynos850 has four (or more) sysregs which are exactly the same?
>> Same registers? Why would they duplicate it?
>>
>
> Ah, no, you are right. Just checked it, they are different. Just first
> couple of registers are similar between blocks, that's why I memorized
> it wrong.
>
> So as I understand, adding those new compatibles follows "describe HW,
> not a driver" rule? Because AFAIU, right now it'll fallback to
> "syscon" compatible anyway.

Yes, they describe hardware. Of course all of these sysregs are similar
as they are just bunch of SFR/MMIO-region, but they have different
roles/features. For example some other devices (users) of syscon/sysreg
should reference specific device, not any sysreg.

On several other architectures we use specific compatibles, so I think
for Samsung we should do the same.

Different case was for Exynos 3/4/5 where there was only one SYSREG.

Best regards,
Krzysztof

2022-11-25 15:26:15

by Sam Protsenko

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 25/11/2022 15:22, Sam Protsenko wrote:
> > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> > <[email protected]> wrote:
> >>
> >> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> >> for them.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >>
> >> ---
> >>
> >> Cc: Sriranjani P <[email protected]>
> >> Cc: Chanho Park <[email protected]>
> >> Cc: Sam Protsenko <[email protected]>
> >> ---
> >
> > Hi Krzysztof,
> >
> > Just curious: what is the rationale for adding those more specific
> > sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> > pretty much the same register layout.
> >
>
> On Exynos5433 all these blocks have different registers. Are you saying
> that Exynos850 has four (or more) sysregs which are exactly the same?
> Same registers? Why would they duplicate it?
>

Ah, no, you are right. Just checked it, they are different. Just first
couple of registers are similar between blocks, that's why I memorized
it wrong.

So as I understand, adding those new compatibles follows "describe HW,
not a driver" rule? Because AFAIU, right now it'll fallback to
"syscon" compatible anyway.

> Best regards,
> Krzysztof
>

2022-11-25 15:41:34

by Sam Protsenko

[permalink] [raw]
Subject: Re: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433

On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Cc: Sriranjani P <[email protected]>
> Cc: Chanho Park <[email protected]>
> Cc: Sam Protsenko <[email protected]>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: [email protected] {
> };
>
> syscon_disp: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1
>

2022-11-25 17:19:26

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Friday, November 25, 2022 8:31 PM
>To: Sam Protsenko <[email protected]>
>Cc: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
>Krzysztof Kozlowski <[email protected]>; Alim Akhtar
><[email protected]>; [email protected]; linux-
>[email protected]; [email protected]; linux-
>[email protected]; Sriranjani P <[email protected]>;
>Chanho Park <[email protected]>
>Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
>dedicated SYSREG compatibles to Exynos5433
>
>On 25/11/2022 15:57, Sam Protsenko wrote:
>> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
>> <[email protected]> wrote:
>>>
>>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>>> <[email protected]> wrote:
>>>>>
>>>>> Exynos5433 has several different SYSREGs, so use dedicated
>>>>> compatibles for them.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>>>>
>>>>> ---
>>>>>
>>>>> Cc: Sriranjani P <[email protected]>
>>>>> Cc: Chanho Park <[email protected]>
>>>>> Cc: Sam Protsenko <[email protected]>
>>>>> ---
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> Just curious: what is the rationale for adding those more specific
>>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>>> pretty much the same register layout.
>>>>
>>>
>>> On Exynos5433 all these blocks have different registers. Are you
>>> saying that Exynos850 has four (or more) sysregs which are exactly the
>same?
>>> Same registers? Why would they duplicate it?
>>>
>>
>> Ah, no, you are right. Just checked it, they are different. Just first
>> couple of registers are similar between blocks, that's why I memorized
>> it wrong.
>>
>> So as I understand, adding those new compatibles follows "describe HW,
>> not a driver" rule? Because AFAIU, right now it'll fallback to
>> "syscon" compatible anyway.
>
>Yes, they describe hardware. Of course all of these sysregs are similar as they
>are just bunch of SFR/MMIO-region, but they have different roles/features.
>For example some other devices (users) of syscon/sysreg should reference
>specific device, not any sysreg.
>
Yes, these are dedicated / extended SFR region to provide IP/Block specific side-band signals / configurations.

>On several other architectures we use specific compatibles, so I think for
>Samsung we should do the same.
>
Yes, most of the SoC's sysreg are dedicated/included in the IP block itself now a day, so make sense to have a dedicated compatible.

>Different case was for Exynos 3/4/5 where there was only one SYSREG.
>
AFAIR, this is correct.

>Best regards,
>Krzysztof


2022-11-25 17:34:15

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
>Krzysztof Kozlowski <[email protected]>; Alim Akhtar
><[email protected]>; [email protected]; linux-
>[email protected]; [email protected]; linux-
>[email protected]
>Cc: Krzysztof Kozlowski <[email protected]>; Sriranjani P
><[email protected]>; Chanho Park <[email protected]>;
>Sam Protsenko <[email protected]>
>Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
>to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>

Reviewed-by: Alim Akhtar <[email protected]>
>---
>
>Cc: Sriranjani P <[email protected]>
>Cc: Chanho Park <[email protected]>
>Cc: Sam Protsenko <[email protected]>
>---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index bd6a354b9cb5..6976e45aa769 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1118,22 +1118,26 @@ hdmiphy: [email protected] {
> };
>
> syscon_disp: [email protected] {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-disp-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: [email protected] {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam0-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: [email protected] {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam1-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: [email protected] {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-fsys-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
>--
>2.34.1


2022-11-25 18:12:01

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
>Krzysztof Kozlowski <[email protected]>; Alim Akhtar
><[email protected]>; [email protected]; linux-
>[email protected]; [email protected]; linux-
>[email protected]
>Cc: Krzysztof Kozlowski <[email protected]>; Sriranjani P
><[email protected]>; Chanho Park <[email protected]>;
>Sam Protsenko <[email protected]>
>Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
>SYSREG compatibles to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
>---
>
>Cc: Sriranjani P <[email protected]>
>Cc: Chanho Park <[email protected]>
>Cc: Sam Protsenko <[email protected]>
>---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>index 68064a5e339c..42357466005e 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
>+ - items:
>+ - enum:
>+ - samsung,exynos5433-cam0-sysreg
>+ - samsung,exynos5433-cam1-sysreg
>+ - samsung,exynos5433-disp-sysreg
>+ - samsung,exynos5433-fsys-sysreg
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ - items:
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ deprecated: true
Any reason to add "deprecated: true" here for above compatible?

>
> reg:
> maxItems: 1
>--
>2.34.1


2022-11-26 05:04:28

by Sriranjani P

[permalink] [raw]
Subject: RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 25 November 2022 16:52
> To: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
Krzysztof
> Kozlowski <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected];
linux-samsung-
> [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>; Sriranjani P
> <[email protected]>; Chanho Park <[email protected]>;
> Sam Protsenko <[email protected]>
> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
> SYSREG compatibles to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Cc: Sriranjani P <[email protected]>
> Cc: Chanho Park <[email protected]>
> Cc: Sam Protsenko <[email protected]>
> ---

Reviewed-by: Sriranjani P <[email protected]>

> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1


2022-11-26 05:08:12

by Sriranjani P

[permalink] [raw]
Subject: RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 25 November 2022 16:52
> To: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
Krzysztof
> Kozlowski <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected];
linux-samsung-
> [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>; Sriranjani P
> <[email protected]>; Chanho Park <[email protected]>;
> Sam Protsenko <[email protected]>
> Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
> to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Cc: Sriranjani P <[email protected]>
> Cc: Chanho Park <[email protected]>
> Cc: Sam Protsenko <[email protected]>
> ---

Reviewed-by: Sriranjani P <[email protected]>

> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: [email protected] {
> };
>
> syscon_disp: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: [email protected] {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1


2022-11-26 13:29:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433

On 25/11/2022 18:06, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:[email protected]]
>> Sent: Friday, November 25, 2022 4:52 PM
>> To: Lee Jones <[email protected]>; Rob Herring <[email protected]>;
>> Krzysztof Kozlowski <[email protected]>; Alim Akhtar
>> <[email protected]>; [email protected]; linux-
>> [email protected]; [email protected]; linux-
>> [email protected]
>> Cc: Krzysztof Kozlowski <[email protected]>; Sriranjani P
>> <[email protected]>; Chanho Park <[email protected]>;
>> Sam Protsenko <[email protected]>
>> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
> dedicated
>> SYSREG compatibles to Exynos5433
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>> them.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
>>
>> Cc: Sriranjani P <[email protected]>
>> Cc: Chanho Park <[email protected]>
>> Cc: Sam Protsenko <[email protected]>
>> ---
>> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> index 68064a5e339c..42357466005e 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysre
>> +++ g.yaml
>> @@ -17,10 +17,21 @@ properties:
>> - samsung,exynos3-sysreg
>> - samsung,exynos4-sysreg
>> - samsung,exynos5-sysreg
>> - - samsung,exynos5433-sysreg
>> - samsung,exynos850-sysreg
>> - samsung,exynosautov9-sysreg
>> - const: syscon
>> + - items:
>> + - enum:
>> + - samsung,exynos5433-cam0-sysreg
>> + - samsung,exynos5433-cam1-sysreg
>> + - samsung,exynos5433-disp-sysreg
>> + - samsung,exynos5433-fsys-sysreg
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + - items:
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + deprecated: true
> Any reason to add "deprecated: true" here for above compatible?

Because it should be used alone as unspecific.

Best regards,
Krzysztof