2023-01-22 03:11:15

by kernel test robot

[permalink] [raw]
Subject: arch/powerpc/include/asm/hw_irq.h:494 mtmsr_isync_irqsafe() warn: inconsistent indenting

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2241ab53cbb5cdb08a6b2d4688feb13971058f65
commit: 0fa6831811f62cfc10415d731bcf9fde2647ad81 powerpc/64: Fix msr_check_and_set/clear MSR[EE] race
date: 4 months ago
config: powerpc-randconfig-m031-20230121 (https://download.01.org/0day-ci/archive/20230122/[email protected]/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>

smatch warnings:
arch/powerpc/include/asm/hw_irq.h:494 mtmsr_isync_irqsafe() warn: inconsistent indenting

vim +494 arch/powerpc/include/asm/hw_irq.h

473
474 static inline unsigned long mtmsr_isync_irqsafe(unsigned long msr)
475 {
476 #ifdef CONFIG_PPC64
477 if (arch_irqs_disabled()) {
478 /*
479 * With soft-masking, MSR[EE] can change from 1 to 0
480 * asynchronously when irqs are disabled, and we don't want to
481 * set MSR[EE] back to 1 here if that has happened. A race-free
482 * way to do this is ensure EE is already 0. Another way it
483 * could be done is with a RESTART_TABLE handler, but that's
484 * probably overkill here.
485 */
486 msr &= ~MSR_EE;
487 mtmsr_isync(msr);
488 irq_soft_mask_set(IRQS_ALL_DISABLED);
489 local_paca->irq_happened |= PACA_IRQ_HARD_DIS;
490 } else
491 #endif
492 mtmsr_isync(msr);
493
> 494 return msr;
495 }
496

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests