Signed-off-by: Sui Jingfeng <[email protected]>
---
include/drm/drm_atomic.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index c023c682301b..0b5271cfb029 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -394,8 +394,7 @@ struct drm_atomic_state {
*
* Indicates whether or not this atomic state was duplicated using
* drm_atomic_helper_duplicate_state(). Drivers and atomic helpers
- * should use this to fixup normal inconsistencies in duplicated
- * states.
+ * should use this to fixup inconsistencies in duplicated states.
*/
bool duplicated : 1;
struct __drm_planes_state *planes;
@@ -412,7 +411,7 @@ struct drm_atomic_state {
*
* Used for signaling unbound planes/connectors.
* When a connector or plane is not bound to any CRTC, it's still important
- * to preserve linearity to prevent the atomic states from being freed to early.
+ * to preserve linearity to prevent the atomic states from being freed too early.
*
* This commit (if set) is not bound to any CRTC, but will be completed when
* drm_atomic_helper_commit_hw_done() is called.
--
2.25.1
Hello Sui,
I would still add something to the commit description even when your
changes are trivial.
Sui Jingfeng <[email protected]> writes:
> Signed-off-by: Sui Jingfeng <[email protected]>
> ---
The fixes look good to me though
Reviewed-by: Javier Martinez Canillas <[email protected]>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 2023/5/17 16:38, Javier Martinez Canillas wrote:
> Hello Sui,
>
> I would still add something to the commit description even when your
> changes are trivial.
OK, that sounds fine. I'm agree.
> Sui Jingfeng <[email protected]> writes:
>
>> Signed-off-by: Sui Jingfeng <[email protected]>
>> ---
> The fixes look good to me though
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
>
Hi, thanks a lot
On 2023/5/17 16:38, Javier Martinez Canillas wrote:
> Hello Sui,
>
> I would still add something to the commit description even when your
> changes are trivial.
Ok, I remember this, I will respin patch with this instruction in mind
in the future.
>
> Sui Jingfeng <[email protected]> writes:
>
>> Signed-off-by: Sui Jingfeng <[email protected]>
>> ---
> The fixes look good to me though
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
>