2023-05-25 03:23:03

by Miaohe Lin

[permalink] [raw]
Subject: [PATCH] sched/psi: make psi_cgroups_enabled static

The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <[email protected]>
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77397f6..2ccb0b2ebd78 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
static int psi_bug __read_mostly;

DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);

#ifdef CONFIG_PSI_DEFAULT_DISABLED
static bool psi_enable;
--
2.27.0



2023-05-25 17:55:16

by Suren Baghdasaryan

[permalink] [raw]
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static

On Wed, May 24, 2023 at 7:43 PM Miaohe Lin <[email protected]> wrote:
>
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Suren Baghdasaryan <[email protected]>

> ---
> kernel/sched/psi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 81fca77397f6..2ccb0b2ebd78 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -140,7 +140,7 @@
> static int psi_bug __read_mostly;
>
> DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
> #ifdef CONFIG_PSI_DEFAULT_DISABLED
> static bool psi_enable;
> --
> 2.27.0
>

2023-05-25 18:03:43

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static

On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <[email protected]>

This was previously submitted by Tom:
https://lore.kernel.org/lkml/[email protected]/

Peter, could you please pick this up?

Thanks!

2023-06-17 03:27:48

by Miaohe Lin

[permalink] [raw]
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static

On 2023/5/26 1:49, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
>> The static key psi_cgroups_enabled is only used inside file psi.c.
>> Make it static.
>>
>> Signed-off-by: Miaohe Lin <[email protected]>
>
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/[email protected]/
>
> Peter, could you please pick this up?
>

friendly ping.. :)

> Thanks!
> .
>


2023-07-06 10:37:23

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static

On Thu, May 25, 2023 at 01:49:37PM -0400, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> > The static key psi_cgroups_enabled is only used inside file psi.c.
> > Make it static.
> >
> > Signed-off-by: Miaohe Lin <[email protected]>
>
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/[email protected]/
>
> Peter, could you please pick this up?

Found it, will queue after -rc1.

Subject: [tip: sched/core] sched/psi: make psi_cgroups_enabled static

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Gitweb: https://git.kernel.org/tip/35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Author: Miaohe Lin <[email protected]>
AuthorDate: Thu, 25 May 2023 18:34:28 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Thu, 13 Jul 2023 15:21:50 +02:00

sched/psi: make psi_cgroups_enabled static

The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Suren Baghdasaryan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77..2ccb0b2 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
static int psi_bug __read_mostly;

DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);

#ifdef CONFIG_PSI_DEFAULT_DISABLED
static bool psi_enable;