2023-06-07 07:27:02

by Sui Jingfeng

Subject: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig

make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-

SYNC include/config/auto.conf.cmd
Checking missing-syscalls for N32
CALL scripts/checksyscalls.sh
Checking missing-syscalls for O32
CALL scripts/checksyscalls.sh
CALL scripts/checksyscalls.sh
MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2

Signed-off-by: Sui Jingfeng <[email protected]>
---
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index a53f475d33df..7457c0b65034 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -5,6 +5,8 @@ config DRM_INGENIC
depends on CMA
depends on OF
depends on COMMON_CLK
+ select REGMAP
+ select REGMAP_MMIO
select DRM_BRIDGE
select DRM_PANEL_BRIDGE
select DRM_KMS_HELPER
--
2.25.1

2023-06-07 10:19:11

by Paul Cercueil

Subject: Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Hi Sui,

Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
>   SYNC    include/config/auto.conf.cmd
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> Signed-off-by: Sui Jingfeng <[email protected]>
> ---
>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..7457c0b65034 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -5,6 +5,8 @@ config DRM_INGENIC
>         depends on CMA
>         depends on OF
>         depends on COMMON_CLK
> +       select REGMAP
> +       select REGMAP_MMIO

nit: order alphabetically (move them after the DRM_* ones).

Cheers,
-Paul

>         select DRM_BRIDGE
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER

2023-06-07 10:42:25

by Sui Jingfeng

Subject: Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Ok, thanks

On 2023/6/7 17:46, Paul Cercueil wrote:
> Hi Sui,
>
> Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
>> Otherwise its failed to pass basic compile test on platform without
>> REGMAP_MMIO selected by defconfig
>>
>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>
>>   SYNC    include/config/auto.conf.cmd
>>   Checking missing-syscalls for N32
>>   CALL    scripts/checksyscalls.sh
>>   Checking missing-syscalls for O32
>>   CALL    scripts/checksyscalls.sh
>>   CALL    scripts/checksyscalls.sh
>>   MODPOST Module.symvers
>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>> make: *** [Makefile:1978: modpost] Error 2
>>
>> Signed-off-by: Sui Jingfeng <[email protected]>
>> ---
>>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ingenic/Kconfig
>> b/drivers/gpu/drm/ingenic/Kconfig
>> index a53f475d33df..7457c0b65034 100644
>> --- a/drivers/gpu/drm/ingenic/Kconfig
>> +++ b/drivers/gpu/drm/ingenic/Kconfig
>> @@ -5,6 +5,8 @@ config DRM_INGENIC
>>         depends on CMA
>>         depends on OF
>>         depends on COMMON_CLK
>> +       select REGMAP
>> +       select REGMAP_MMIO
> nit: order alphabetically (move them after the DRM_* ones).
>
> Cheers,
> -Paul
>
>>         select DRM_BRIDGE
>>         select DRM_PANEL_BRIDGE
>>         select DRM_KMS_HELPER

--
Jingfeng

2023-06-15 07:32:37

by Sui Jingfeng

Subject: Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Hi,

On 2023/6/7 17:46, Paul Cercueil wrote:
> Hi Sui,
>
> Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
>> Otherwise its failed to pass basic compile test on platform without
>> REGMAP_MMIO selected by defconfig
>>
>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>
>>   SYNC    include/config/auto.conf.cmd
>>   Checking missing-syscalls for N32
>>   CALL    scripts/checksyscalls.sh
>>   Checking missing-syscalls for O32
>>   CALL    scripts/checksyscalls.sh
>>   CALL    scripts/checksyscalls.sh
>>   MODPOST Module.symvers
>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>> make: *** [Makefile:1978: modpost] Error 2
>>
>> Signed-off-by: Sui Jingfeng <[email protected]>
>> ---
>>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ingenic/Kconfig
>> b/drivers/gpu/drm/ingenic/Kconfig
>> index a53f475d33df..7457c0b65034 100644
>> --- a/drivers/gpu/drm/ingenic/Kconfig
>> +++ b/drivers/gpu/drm/ingenic/Kconfig
>> @@ -5,6 +5,8 @@ config DRM_INGENIC
>>         depends on CMA
>>         depends on OF
>>         depends on COMMON_CLK
>> +       select REGMAP
>> +       select REGMAP_MMIO
> nit: order alphabetically (move them after the DRM_* ones).

Fixed, I already send a updated version[1].

[1]
https://lore.kernel.org/dri-devel/[email protected]/

> Cheers,
> -Paul
>
>>         select DRM_BRIDGE
>>         select DRM_PANEL_BRIDGE
>>         select DRM_KMS_HELPER

--
Jingfeng