2023-06-22 08:01:32

by Johan Hovold

Subject: [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active()

The runtime PM state must be updated while runtime PM is disabled for
the change to take effect.

Drop the bogus pm_runtime_set_active() which left the PM state set to
suspended (as it should be or the clock would not be enabled when the
device is resumed).

Signed-off-by: Johan Hovold <[email protected]>
---
drivers/dma/mediatek/mtk-uart-apdma.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index a1517ef1f4a0..92864c9371a3 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev)
}

pm_runtime_enable(&pdev->dev);
- pm_runtime_set_active(&pdev->dev);

rc = dma_async_device_register(&mtkd->ddev);
if (rc)
--
2.39.3

2023-07-11 17:01:32

by Vinod Koul

Subject: Re: [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active()

On Thu, 22 Jun 2023 09:51:50 +0200, Johan Hovold wrote:
> The runtime PM state must be updated while runtime PM is disabled for
> the change to take effect.
>
> Drop the bogus pm_runtime_set_active() which left the PM state set to
> suspended (as it should be or the clock would not be enabled when the
> device is resumed).
>
> [...]

Applied, thanks!

[1/1] dmaengine: mediatek: drop bogus pm_runtime_set_active()
commit: 1775a0d9f021739a69e4cf12c049801c9cf1a072

Best regards,
--
~Vinod