2023-06-27 01:48:33

by Keoseong Park

[permalink] [raw]
Subject: [PATCH] scsi: ufs: Remove unused function declaration

Commit 2468da61ea09 ("scsi: ufs: core: mcq: Configure operation and
runtime interface") added ufshcd_mcq_select_mcq_mode(), but
it's not used anywhere. So remove it.

Signed-off-by: Keoseong Park <[email protected]>
---
drivers/ufs/core/ufshcd-priv.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
index 9566a95aeed9..0f3bd943b58b 100644
--- a/drivers/ufs/core/ufshcd-priv.h
+++ b/drivers/ufs/core/ufshcd-priv.h
@@ -68,7 +68,6 @@ int ufshcd_mcq_decide_queue_depth(struct ufs_hba *hba);
int ufshcd_mcq_memory_alloc(struct ufs_hba *hba);
void ufshcd_mcq_make_queues_operational(struct ufs_hba *hba);
void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32 max_active_cmds);
-void ufshcd_mcq_select_mcq_mode(struct ufs_hba *hba);
u32 ufshcd_mcq_read_cqis(struct ufs_hba *hba, int i);
void ufshcd_mcq_write_cqis(struct ufs_hba *hba, u32 val, int i);
struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
--
2.17.1



2023-06-28 23:16:19

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: Remove unused function declaration

On 6/26/23 18:29, Keoseong Park wrote:
> Commit 2468da61ea09 ("scsi: ufs: core: mcq: Configure operation and
> runtime interface") added ufshcd_mcq_select_mcq_mode(), but
> it's not used anywhere. So remove it.

Reviewed-by: Bart Van Assche <[email protected]>

2023-06-29 02:30:40

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: Remove unused function declaration


Keoseong,

> Commit 2468da61ea09 ("scsi: ufs: core: mcq: Configure operation and
> runtime interface") added ufshcd_mcq_select_mcq_mode(), but it's not
> used anywhere. So remove it.

Applied to 6.5/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering