2023-07-20 08:07:05

by hanyu001

Subject: [PATCH] drivers: gpio: Remove unnecessary spaces

Fix checkpatch warnings:

./drivers/gpio/gpio-pca953x.c:1352: ERROR: space prohibited after that
open parenthesis '('
./drivers/gpio/gpio-pca953x.c:1353: ERROR: space prohibited after that
open parenthesis '('
./drivers/gpio/gpio-pca953x.c:1354: ERROR: space prohibited after that
open parenthesis '('
./drivers/gpio/gpio-pca953x.c:1359: ERROR: space prohibited after that
open parenthesis '('
./drivers/gpio/gpio-pca953x.c:1360: ERROR: space prohibited after that
open parenthesis '('

Signed-off-by: Yu Han <[email protected]>
---
drivers/gpio/gpio-pca953x.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index a806a3c..7f4f7ee 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1349,15 +1349,15 @@ static int pca953x_resume(struct device *dev)
{ .compatible = "maxim,max7315", .data = OF_953X( 8, PCA_INT), },
{ .compatible = "maxim,max7318", .data = OF_953X(16, PCA_INT), },

- { .compatible = "ti,pca6107", .data = OF_953X( 8, PCA_INT), },
- { .compatible = "ti,pca9536", .data = OF_953X( 4, 0), },
- { .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
+ { .compatible = "ti,pca6107", .data = OF_953X(8, PCA_INT), },
+ { .compatible = "ti,pca9536", .data = OF_953X(4, 0), },
+ { .compatible = "ti,tca6408", .data = OF_953X(8, PCA_INT), },
{ .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
{ .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
{ .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },

- { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
- { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
+ { .compatible = "onnn,cat9554", .data = OF_953X(8, PCA_INT), },
+ { .compatible = "onnn,pca9654", .data = OF_953X(8, PCA_INT), },
{ .compatible = "onnn,pca9655", .data = OF_953X(16, PCA_INT), },

{ .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },

2023-07-20 15:02:46

by Bartosz Golaszewski

Subject: Re: [PATCH] drivers: gpio: Remove unnecessary spaces

On Thu, Jul 20, 2023 at 8:55 AM <[email protected]> wrote:
>
> Fix checkpatch warnings:
>
> ./drivers/gpio/gpio-pca953x.c:1352: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1353: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1354: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1359: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1360: ERROR: space prohibited after that
> open parenthesis '('
>
> Signed-off-by: Yu Han <[email protected]>
> ---
> drivers/gpio/gpio-pca953x.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index a806a3c..7f4f7ee 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1349,15 +1349,15 @@ static int pca953x_resume(struct device *dev)
> { .compatible = "maxim,max7315", .data = OF_953X( 8, PCA_INT), },
> { .compatible = "maxim,max7318", .data = OF_953X(16, PCA_INT), },
>
> - { .compatible = "ti,pca6107", .data = OF_953X( 8, PCA_INT), },
> - { .compatible = "ti,pca9536", .data = OF_953X( 4, 0), },
> - { .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
> + { .compatible = "ti,pca6107", .data = OF_953X(8, PCA_INT), },
> + { .compatible = "ti,pca9536", .data = OF_953X(4, 0), },
> + { .compatible = "ti,tca6408", .data = OF_953X(8, PCA_INT), },
> { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
> { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
> { .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
>
> - { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
> - { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
> + { .compatible = "onnn,cat9554", .data = OF_953X(8, PCA_INT), },
> + { .compatible = "onnn,pca9654", .data = OF_953X(8, PCA_INT), },
> { .compatible = "onnn,pca9655", .data = OF_953X(16, PCA_INT), },
>
> { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },

This doesn't apply to my for-next tree. And the commit message should
be: "gpio: pca953x: ..."

Bart