Hi,
This adds PCIe v2 support for RK3588. The series has been tested with
the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1)
and Radxa Rock 5B (&pcie2x1l2).
Changes since v3:
* https://lore.kernel.org/all/[email protected]/
* Remove unneeded quotes in patch 1 (msi handling)
* Update patch description of patch 2 (interrupt names) adding information
about Rockchip specific parts
Changes since v2:
* https://lore.kernel.org/all/[email protected]/
* Removed num-ib-windows/num-ob-windows/num-viewport from DT
* Added patch making 'msi' irq optional, if 'msi-map' property is available
* Updated binding according two discussion with Serge Semin, I provided two
options by adding one extra patch that should be squashed into the main
one or dropped depending on preferences from DT binding maintainers.
* Collected Reviewed-by/Tested-by from Jagan Teki
Changes since v1:
* https://lore.kernel.org/all/[email protected]/
* Dropped patch adding 'RK3588' (queued by Rob)
* Updated patch adding legacy-interrupt-controller according to comments
from Rob and Serge
- added missing additionalProperties: false
- added all properties to new required property
- removed useless quotes around interrupt-controller
- added Rob's Reviewed-by
* Updated patch adding the missing RK356x/RK3588 interrupt names, so that it
provides more details about the interrupts
* Updated the DT patch according to the comment from Jonas Karlman, so that
the addresses are in 32 bit address space starting at 0x40000000
[0] https://lore.kernel.org/all/[email protected]/
Thanks,
-- Sebastian
Sebastian Reichel (5):
dt-bindings: PCI: dwc: improve msi handling
dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue
dt-bindings: PCI: dwc: rockchip: Use generic binding
dt-bindings: PCI: dwc: rockchip: Add missing
legacy-interrupt-controller
arm64: dts: rockchip: rk3588: add PCIe2 support
.../bindings/pci/rockchip-dw-pcie.yaml | 70 ++++++++++++
.../devicetree/bindings/pci/snps,dw-pcie.yaml | 18 +++-
arch/arm64/boot/dts/rockchip/rk3588.dtsi | 51 +++++++++
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 102 ++++++++++++++++++
4 files changed, 237 insertions(+), 4 deletions(-)
--
2.40.1
On Mon, Jul 31, 2023 at 06:57:18PM +0200, Sebastian Reichel wrote:
> Hi,
>
> This adds PCIe v2 support for RK3588. The series has been tested with
> the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1)
> and Radxa Rock 5B (&pcie2x1l2).
>
> Changes since v3:
> * https://lore.kernel.org/all/[email protected]/
> * Remove unneeded quotes in patch 1 (msi handling)
> * Update patch description of patch 2 (interrupt names) adding information
> about Rockchip specific parts
>
> Changes since v2:
> * https://lore.kernel.org/all/[email protected]/
> * Removed num-ib-windows/num-ob-windows/num-viewport from DT
> * Added patch making 'msi' irq optional, if 'msi-map' property is available
> * Updated binding according two discussion with Serge Semin, I provided two
> options by adding one extra patch that should be squashed into the main
> one or dropped depending on preferences from DT binding maintainers.
> * Collected Reviewed-by/Tested-by from Jagan Teki
>
> Changes since v1:
> * https://lore.kernel.org/all/[email protected]/
> * Dropped patch adding 'RK3588' (queued by Rob)
> * Updated patch adding legacy-interrupt-controller according to comments
> from Rob and Serge
> - added missing additionalProperties: false
> - added all properties to new required property
> - removed useless quotes around interrupt-controller
> - added Rob's Reviewed-by
> * Updated patch adding the missing RK356x/RK3588 interrupt names, so that it
> provides more details about the interrupts
> * Updated the DT patch according to the comment from Jonas Karlman, so that
> the addresses are in 32 bit address space starting at 0x40000000
>
> [0] https://lore.kernel.org/all/[email protected]/
>
> Thanks,
>
> -- Sebastian
>
> Sebastian Reichel (5):
> dt-bindings: PCI: dwc: improve msi handling
> dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue
> dt-bindings: PCI: dwc: rockchip: Use generic binding
> dt-bindings: PCI: dwc: rockchip: Add missing
> legacy-interrupt-controller
> arm64: dts: rockchip: rk3588: add PCIe2 support
Patches 1-4 applied.
Rob
On Mon, 31 Jul 2023 18:57:18 +0200, Sebastian Reichel wrote:
> This adds PCIe v2 support for RK3588. The series has been tested with
> the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1)
> and Radxa Rock 5B (&pcie2x1l2).
>
> Changes since v3:
> * https://lore.kernel.org/all/[email protected]/
> * Remove unneeded quotes in patch 1 (msi handling)
> * Update patch description of patch 2 (interrupt names) adding information
> about Rockchip specific parts
>
> [...]
Applied, thanks!
[5/5] arm64: dts: rockchip: rk3588: add PCIe2 support
commit: 8d81b77f4c49f8ee1432c20c22bf0f03c2937a88
Best regards,
--
Heiko Stuebner <[email protected]>