2023-09-12 14:30:37

by Richard Fitzgerald

Subject: [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode

Do not allow the CS35L56 to be put into its lowest power
"hibernation" mode. This only affects I2C because "hibernation"
is already disabled on SPI.

Recent firmwares need a different wake-up sequence. Until
that sequence has been specified, the chip "hibernation" mode
must be disabled otherwise it can intermittently fail to wake.

Signed-off-by: Richard Fitzgerald <[email protected]>
---
sound/pci/hda/cs35l56_hda_i2c.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c
index 83e4acdd89ac..757a4d193e0f 100644
--- a/sound/pci/hda/cs35l56_hda_i2c.c
+++ b/sound/pci/hda/cs35l56_hda_i2c.c
@@ -21,7 +21,6 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt)
return -ENOMEM;

cs35l56->base.dev = &clt->dev;
- cs35l56->base.can_hibernate = true;
cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c);
if (IS_ERR(cs35l56->base.regmap)) {
ret = PTR_ERR(cs35l56->base.regmap);
--
2.30.2

2023-09-13 12:39:41

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode

On Tue, 12 Sep 2023 15:27:39 +0200,
Richard Fitzgerald wrote:
>
> Do not allow the CS35L56 to be put into its lowest power
> "hibernation" mode. This only affects I2C because "hibernation"
> is already disabled on SPI.
>
> Recent firmwares need a different wake-up sequence. Until
> that sequence has been specified, the chip "hibernation" mode
> must be disabled otherwise it can intermittently fail to wake.
>
> Signed-off-by: Richard Fitzgerald <[email protected]>

Thanks, applied.


Takashi