2023-09-17 08:36:06

by Bragatheswaran Manickavel

Subject: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name

Added identifier names to respective definitions for fix
warnings reported by checkpatch.pl

WARNING: function definition argument 'void *' should also have an identifier name
WARNING: function definition argument 'int *' should also have an identifier name
Signed-off-by: Bragatheswaran Manickavel <[email protected]>
---
drivers/thermal/imx8mm_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index 14111ccf6e4c..5dc6c18f12df 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -78,7 +78,7 @@
struct thermal_soc_data {
u32 num_sensors;
u32 version;
- int (*get_temp)(void *, int *);
+ int (*get_temp)(void *data, int *temp);
};

struct tmu_sensor {
--
2.34.1

2023-09-19 17:10:16

by Bragatheswaran Manickavel

Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name

On 17/09/23 14:04, Bragatheswaran Manickavel wrote:

>Added identifier names to respective definitions for fix
>warnings reported by checkpatch.pl
>
>WARNING: function definition argument 'void *' should also have an
identifier name
>WARNING: function definition argument 'int *' should also have an
identifier name
>Signed-off-by: Bragatheswaran Manickavel <[email protected]>
>---
> drivers/thermal/imx8mm_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/thermal/imx8mm_thermal.c
b/drivers/thermal/imx8mm_thermal.c
>index 14111ccf6e4c..5dc6c18f12df 100644
>--- a/drivers/thermal/imx8mm_thermal.c
>+++ b/drivers/thermal/imx8mm_thermal.c
>@@ -78,7 +78,7 @@
> struct thermal_soc_data {
>     u32 num_sensors;
>     u32 version;
>-    int (*get_temp)(void *, int *);
>+    int (*get_temp)(void *data, int *temp);
> };
>
> struct tmu_sensor {

Gentle remainder

2023-09-22 13:17:32

by Bragatheswaran Manickavel

Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name

On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
> Added identifier names to respective definitions for fix
> warnings reported by checkpatch.pl
>
> WARNING: function definition argument 'void *' should also have an identifier name
> WARNING: function definition argument 'int *' should also have an identifier name
> Signed-off-by: Bragatheswaran Manickavel <[email protected]>
> ---
> drivers/thermal/imx8mm_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index 14111ccf6e4c..5dc6c18f12df 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -78,7 +78,7 @@
> struct thermal_soc_data {
> u32 num_sensors;
> u32 version;
> - int (*get_temp)(void *, int *);
> + int (*get_temp)(void *data, int *temp);
> };
>
> struct tmu_sensor {

Hi Team, Could someone help in reviewing it.

Thanks,
Bragathe