2023-09-19 04:30:53

by Randy Dunlap

Subject: [PATCH] power: supply: pm8916_lbc: observe EXTCON config setting

When CONFIG_EXTCON=m and CONFIG_CHARGER_PM8916_LBC=y, there are
build errors. Fix them by having CHARGER_PM8916_LBC depend on the
setting of EXTCON.

aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_state_changed_irq':
pm8916_lbc.c:(.text+0xe8): undefined reference to `extcon_set_state_sync'
aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_probe':
pm8916_lbc.c:(.text+0x638): undefined reference to `devm_extcon_dev_allocate'
aarch64-linux-ld: pm8916_lbc.c:(.text+0x650): undefined reference to `devm_extcon_dev_register'
aarch64-linux-ld: pm8916_lbc.c:(.text+0x688): undefined reference to `extcon_set_state_sync'

Fixes: f8d7a3d21160 ("power: supply: Add driver for pm8916 lbc")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Nikita Travkin <[email protected]>
Cc: Sebastian Reichel <[email protected]>
Cc: [email protected]
---
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -643,6 +643,7 @@ config BATTERY_PM8916_BMS_VM
config CHARGER_PM8916_LBC
tristate "Qualcomm PM8916 Linear Battery Charger support"
depends on MFD_SPMI_PMIC || COMPILE_TEST
+ depends on EXTCON || !EXTCON
help
Say Y here to add support for Linear Battery Charger block
found in some Qualcomm PMICs such as PM8916. This hardware

2023-09-19 22:26:58

by Sebastian Reichel

Subject: Re: [PATCH] power: supply: pm8916_lbc: observe EXTCON config setting

On Mon, 18 Sep 2023 13:58:25 -0700, Randy Dunlap wrote:
> When CONFIG_EXTCON=m and CONFIG_CHARGER_PM8916_LBC=y, there are
> build errors. Fix them by having CHARGER_PM8916_LBC depend on the
> setting of EXTCON.
>
> aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_state_changed_irq':
> pm8916_lbc.c:(.text+0xe8): undefined reference to `extcon_set_state_sync'
> aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_probe':
> pm8916_lbc.c:(.text+0x638): undefined reference to `devm_extcon_dev_allocate'
> aarch64-linux-ld: pm8916_lbc.c:(.text+0x650): undefined reference to `devm_extcon_dev_register'
> aarch64-linux-ld: pm8916_lbc.c:(.text+0x688): undefined reference to `extcon_set_state_sync'
>
> [...]

Applied, thanks!

[1/1] power: supply: pm8916_lbc: observe EXTCON config setting
commit: a6c6a5fe2a08172c2e045588531f0e05a6c296cf

Best regards,
--
Sebastian Reichel <[email protected]>