Here's some random chromeos driver cleanups that have been sitting in my
tree. I've noticed them while browsing the code for something I'm
working on.
Stephen Boyd (4):
platform/chrome: cros_ec_typec: Use semi-colons instead of commas
platform/chrome: cros_ec_typec: Use dev_err_probe() more
platform/chrome: cros_typec_vdm: Mark port_amode_ops const
platform/chrome: cros_ec_proto: Mark outdata as const
drivers/platform/chrome/cros_ec_proto.c | 2 +-
drivers/platform/chrome/cros_ec_typec.c | 18 +++++++++---------
drivers/platform/chrome/cros_typec_vdm.c | 2 +-
drivers/platform/chrome/cros_typec_vdm.h | 2 +-
include/linux/platform_data/cros_ec_proto.h | 2 +-
5 files changed, 13 insertions(+), 13 deletions(-)
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
--
https://chromeos.dev
These should be semi-colons so that one statement is per line.
Cc: Prashant Malani <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d0b4d3fc40ed..82e7d08b52c7 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -271,9 +271,9 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec,
struct typec_altmode *amode;
/* All PD capable CrOS devices are assumed to support DP altmode. */
- desc.svid = USB_TYPEC_DP_SID,
- desc.mode = USB_TYPEC_DP_MODE,
- desc.vdo = DP_PORT_VDO,
+ desc.svid = USB_TYPEC_DP_SID;
+ desc.mode = USB_TYPEC_DP_MODE;
+ desc.vdo = DP_PORT_VDO;
amode = typec_port_register_altmode(port->port, &desc);
if (IS_ERR(amode))
return PTR_ERR(amode);
@@ -287,8 +287,8 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec,
* here for now.
*/
memset(&desc, 0, sizeof(desc));
- desc.svid = USB_TYPEC_TBT_SID,
- desc.mode = TYPEC_ANY_MODE,
+ desc.svid = USB_TYPEC_TBT_SID;
+ desc.mode = TYPEC_ANY_MODE;
amode = typec_port_register_altmode(port->port, &desc);
if (IS_ERR(amode))
return PTR_ERR(amode);
--
https://chromeos.dev
Hi Stephen,
Thanks for submitting the patch series.
On Oct 02 17:34, Stephen Boyd wrote:
> Here's some random chromeos driver cleanups that have been sitting in my
> tree. I've noticed them while browsing the code for something I'm
> working on.
>
> Stephen Boyd (4):
> platform/chrome: cros_ec_typec: Use semi-colons instead of commas
> platform/chrome: cros_ec_typec: Use dev_err_probe() more
> platform/chrome: cros_typec_vdm: Mark port_amode_ops const
> platform/chrome: cros_ec_proto: Mark outdata as const
For the series:
Acked-by: Prashant Malani <[email protected]>
BR,
-Prashant
Hello:
This series was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <[email protected]>:
On Mon, 2 Oct 2023 17:34:24 -0700 you wrote:
> Here's some random chromeos driver cleanups that have been sitting in my
> tree. I've noticed them while browsing the code for something I'm
> working on.
>
> Stephen Boyd (4):
> platform/chrome: cros_ec_typec: Use semi-colons instead of commas
> platform/chrome: cros_ec_typec: Use dev_err_probe() more
> platform/chrome: cros_typec_vdm: Mark port_amode_ops const
> platform/chrome: cros_ec_proto: Mark outdata as const
>
> [...]
Here is the summary with links:
- [1/4] platform/chrome: cros_ec_typec: Use semi-colons instead of commas
https://git.kernel.org/chrome-platform/c/a88f6ef67957
- [2/4] platform/chrome: cros_ec_typec: Use dev_err_probe() more
https://git.kernel.org/chrome-platform/c/2b055bf8ac84
- [3/4] platform/chrome: cros_typec_vdm: Mark port_amode_ops const
https://git.kernel.org/chrome-platform/c/14e7c01cc349
- [4/4] platform/chrome: cros_ec_proto: Mark outdata as const
https://git.kernel.org/chrome-platform/c/2f3dd39e2b49
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Hello:
This series was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <[email protected]>:
On Mon, 2 Oct 2023 17:34:24 -0700 you wrote:
> Here's some random chromeos driver cleanups that have been sitting in my
> tree. I've noticed them while browsing the code for something I'm
> working on.
>
> Stephen Boyd (4):
> platform/chrome: cros_ec_typec: Use semi-colons instead of commas
> platform/chrome: cros_ec_typec: Use dev_err_probe() more
> platform/chrome: cros_typec_vdm: Mark port_amode_ops const
> platform/chrome: cros_ec_proto: Mark outdata as const
>
> [...]
Here is the summary with links:
- [1/4] platform/chrome: cros_ec_typec: Use semi-colons instead of commas
https://git.kernel.org/chrome-platform/c/a88f6ef67957
- [2/4] platform/chrome: cros_ec_typec: Use dev_err_probe() more
https://git.kernel.org/chrome-platform/c/2b055bf8ac84
- [3/4] platform/chrome: cros_typec_vdm: Mark port_amode_ops const
https://git.kernel.org/chrome-platform/c/14e7c01cc349
- [4/4] platform/chrome: cros_ec_proto: Mark outdata as const
https://git.kernel.org/chrome-platform/c/2f3dd39e2b49
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html