2023-10-29 23:51:15

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH Resend] Fix line Length

On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
>
>
> On Sun, 29 Oct 2023, Dorine Tipo wrote:
>
> > Signed-off-by: Dorine Tipo <[email protected]>
> >
> > Fix the line lengths of lines 8 and 49
>
> The Signed off by line should be here, below the log message. Please see
> the patches sent by others.
>
> > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > export PATH=$PATH:/igt/bin/
> > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
>
> There was a suggestion that it was better to keep this as one line.
>

Hi Julia,

The submitter touched one of CI scripts for the DRM subsystem. To test
this patch, there must be a way to run these scripts locally (which
may requires non-trivial setup).

Cc'ed DRM maintainers.

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.05 kB)
signature.asc (235.00 B)
Download all attachments

2023-10-30 06:13:21

by Julia Lawall

[permalink] [raw]
Subject: Re: [PATCH Resend] Fix line Length



On Mon, 30 Oct 2023, Bagas Sanjaya wrote:

> On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> >
> >
> > On Sun, 29 Oct 2023, Dorine Tipo wrote:
> >
> > > Signed-off-by: Dorine Tipo <[email protected]>
> > >
> > > Fix the line lengths of lines 8 and 49
> >
> > The Signed off by line should be here, below the log message. Please see
> > the patches sent by others.
> >
> > > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > > export PATH=$PATH:/igt/bin/
> > > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
> >
> > There was a suggestion that it was better to keep this as one line.
> >
>
> Hi Julia,
>
> The submitter touched one of CI scripts for the DRM subsystem. To test
> this patch, there must be a way to run these scripts locally (which
> may requires non-trivial setup).
>
> Cc'ed DRM maintainers.

There is a DRM outreachy project. I think that motivated this patch.

julia

2023-10-30 11:37:10

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH Resend] Fix line Length

On 30/10/2023 13:12, Julia Lawall wrote:
>
>
> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>
>> Hi Julia,
>>
>> The submitter touched one of CI scripts for the DRM subsystem. To test
>> this patch, there must be a way to run these scripts locally (which
>> may requires non-trivial setup).
>>
>> Cc'ed DRM maintainers.
>
> There is a DRM outreachy project. I think that motivated this patch.
>

OK, thanks!

--
An old man doll... just what I always wanted! - Clara

2023-10-31 18:36:52

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH Resend] Fix line Length



On 30/10/2023 08:36, Bagas Sanjaya wrote:
> On 30/10/2023 13:12, Julia Lawall wrote:
>>
>>
>> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>>
>>> Hi Julia,
>>>
>>> The submitter touched one of CI scripts for the DRM subsystem. To test
>>> this patch, there must be a way to run these scripts locally (which
>>> may requires non-trivial setup).

Instructions to test it is on the docs:

https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree

>>>
>>> Cc'ed DRM maintainers.
>>
>> There is a DRM outreachy project. I think that motivated this patch.

Yes :)

>>
>
> OK, thanks!
>


Thanks
Helen

2023-11-01 02:11:49

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH Resend] Fix line Length

On Tue, Oct 31, 2023 at 03:36:30PM -0300, Helen Koike wrote:
>
>
> On 30/10/2023 08:36, Bagas Sanjaya wrote:
> > On 30/10/2023 13:12, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> > >
> > > > Hi Julia,
> > > >
> > > > The submitter touched one of CI scripts for the DRM subsystem. To test
> > > > this patch, there must be a way to run these scripts locally (which
> > > > may requires non-trivial setup).
>
> Instructions to test it is on the docs:
>
> https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree

Thanks for the pointer!

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (718.00 B)
signature.asc (235.00 B)
Download all attachments