2023-12-07 16:15:39

by Rob Herring (Arm)

Subject: [PATCH] firmware: microchip: Replace of_device.h with explicit include

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it was merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. Soon the implicit includes are going to be removed.

of_device.h isn't needed, but platform_device.h is.

Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
drivers/firmware/microchip/mpfs-auto-update.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c
index d56a95b36b85..81f5f62e34fc 100644
--- a/drivers/firmware/microchip/mpfs-auto-update.c
+++ b/drivers/firmware/microchip/mpfs-auto-update.c
@@ -14,7 +14,7 @@
#include <linux/math.h>
#include <linux/module.h>
#include <linux/mtd/mtd.h>
-#include <linux/of_device.h>
+#include <linux/platform_device.h>
#include <linux/sizes.h>

#include <soc/microchip/mpfs.h>
--
2.42.0

2023-12-07 16:50:02

by Conor Dooley

Subject: Re: [PATCH] firmware: microchip: Replace of_device.h with explicit include

From: Conor Dooley <[email protected]>

On Thu, 07 Dec 2023 10:14:30 -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it was merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. Soon the implicit includes are going to be removed.
>
> of_device.h isn't needed, but platform_device.h is.
>
> [...]

Sorry about that Rob.. I'll also add the maintainers coverage you
noticed was missing.

[1/1] firmware: microchip: Replace of_device.h with explicit include
https://git.kernel.org/conor/c/405820eae72f

Thanks,
Conor.