2024-02-12 07:32:03

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: s3c64xx: make s3c6410_subsys const

On 11/02/2024 16:57, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type, move the s3c6410_subsys variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---

I just noticed you sent quite the same change for the same subarch.
Please perform changes all at once. Squashed.

Best regards,
Krzysztof



2024-02-12 11:34:49

by Ricardo B. Marliere

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: s3c64xx: make s3c6410_subsys const

Hi Krzysztof,

On 12 Feb 08:31, Krzysztof Kozlowski wrote:
> On 11/02/2024 16:57, Ricardo B. Marliere wrote:
> > Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> > a const *"), the driver core can properly handle constant struct
> > bus_type, move the s3c6410_subsys variable to be a constant structure as
> > well, placing it into read-only memory which can not be modified at
> > runtime.
> >
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Suggested-by: Greg Kroah-Hartman <[email protected]>
> > Signed-off-by: Ricardo B. Marliere <[email protected]>
> > ---
>
> I just noticed you sent quite the same change for the same subarch.
> Please perform changes all at once. Squashed.

Yes, sorry about that. The reason for this is that I initially started
splitting up this commit into proper submissions:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=bus_cleanup&id=26105f537f0c60eacfeb430abd2e05d7ddcdd8aa

And only after that I started grepping the tree for the other users.

>
> Best regards,
> Krzysztof
>