2024-03-27 15:14:28

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically

On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote:
> -void init_dummy_netdev(struct net_device *dev)
> +void init_dummy_netdev_core(struct net_device *dev)

Can init_dummy_netdev_core() be a static function (and no export)?
alloc_netdev_dummy() is probably going to be the only user.

I'd also lean towards squashing the two commits into one.