2008-07-31 20:38:54

by Eduardo Habkost

Subject: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()

xen-netfront never called netif_start_queue() and was was waking the
queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().

Signed-off-by: Eduardo Habkost <[email protected]>
---
drivers/net/xen-netfront.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 902bbe7..c749bdb 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
}
spin_unlock_bh(&np->rx_lock);

- xennet_maybe_wake_tx(dev);
+ netif_start_queue(dev);

return 0;
}
--
1.5.5.GIT

2008-08-07 06:12:34

by Jeff Garzik

Subject: Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()

Eduardo Habkost wrote:
> xen-netfront never called netif_start_queue() and was was waking the
> queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().
>
> Signed-off-by: Eduardo Habkost <[email protected]>
> ---
> drivers/net/xen-netfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 902bbe7..c749bdb 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
> }
> spin_unlock_bh(&np->rx_lock);
>
> - xennet_maybe_wake_tx(dev);
> + netif_start_queue(dev);
>

applied