2009-01-08 00:22:48

by Harvey Harrison

Subject: [PATCH] pci: __FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison <[email protected]>
---
I guess checkpatch isn't a string enough warning :-/

drivers/pci/pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index c12f6c7..779f749 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -651,7 +651,7 @@ static int pci_save_pcie_state(struct pci_dev *dev)

save_state = pci_find_saved_cap(dev, PCI_CAP_ID_EXP);
if (!save_state) {
- dev_err(&dev->dev, "buffer not found in %s\n", __FUNCTION__);
+ dev_err(&dev->dev, "buffer not found in %s\n", __func__);
return -ENOMEM;
}
cap = (u16 *)&save_state->data[0];
@@ -694,7 +694,7 @@ static int pci_save_pcix_state(struct pci_dev *dev)

save_state = pci_find_saved_cap(dev, PCI_CAP_ID_PCIX);
if (!save_state) {
- dev_err(&dev->dev, "buffer not found in %s\n", __FUNCTION__);
+ dev_err(&dev->dev, "buffer not found in %s\n", __func__);
return -ENOMEM;
}

--
1.6.1.94.g9388

2009-01-16 18:18:21

by Jesse Barnes

Subject: Re: [PATCH] pci: __FUNCTION__ is gcc-specific, use __func__

On Wednesday, January 7, 2009 4:22 pm Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> I guess checkpatch isn't a string enough warning :-/

Applied, thanks.

--
Jesse Barnes, Intel Open Source Technology Center