2009-04-22 07:55:31

by Pavel Machek

[permalink] [raw]
Subject: 2.6.30-rc2 to -rc1 regression on arm


...it now fails to compile in arch/arm/kernel/sys_oabi-compat.c ,
complaining about missing prototypes for kmalloc/kfree.

I guess it should be easy to fix.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


2009-04-22 08:03:42

by Sascha Hauer

[permalink] [raw]
Subject: Re: 2.6.30-rc2 to -rc1 regression on arm

On Wed, Apr 22, 2009 at 09:58:17AM +0200, Pavel Machek wrote:
>
> ...it now fails to compile in arch/arm/kernel/sys_oabi-compat.c ,
> complaining about missing prototypes for kmalloc/kfree.
>
> I guess it should be easy to fix.

This is already fixed in post rc2:

commit cbb55092a674bcfd9774637a06d0f1511763aa2c
Author: eric miao <[email protected]>
Date: Thu Apr 16 09:55:23 2009 +0100

[ARM] 5453/1: fix building breakage of sys_oabi-compat.c due to missing kmalloc/kfree

It seems that declarations of kmalloc/kfree are missed, explicitly
include it.

Signed-off-by: Eric Miao <[email protected]>
Signed-off-by: Russell King <[email protected]>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2009-04-22 08:10:31

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: 2.6.30-rc2 to -rc1 regression on arm

hi pavel,

El Wed, Apr 22, 2009 at 09:58:17AM +0200 Pavel Machek ha dit:

> ...it now fails to compile in arch/arm/kernel/sys_oabi-compat.c ,
> complaining about missing prototypes for kmalloc/kfree.

AFAIK this is fixed in 2.6.30-rc3

see also http://lkml.org/lkml/2009/4/15/105

--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona

They that can give up essential liberty to obtain a little
temporary safety deserve neither liberty nor safety
(Benjamin Franklin)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-

2009-04-22 08:10:56

by Daniel Mack

[permalink] [raw]
Subject: Re: 2.6.30-rc2 to -rc1 regression on arm

On Wed, Apr 22, 2009 at 09:58:17AM +0200, Pavel Machek wrote:
> ...it now fails to compile in arch/arm/kernel/sys_oabi-compat.c ,
> complaining about missing prototypes for kmalloc/kfree.
>
> I guess it should be easy to fix.

It _was_ easy to fix, yes:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=cbb55092a674bcfd9774637a06d0f1511763aa2c