2009-12-01 06:56:24

by Kyle McMartin

Subject: [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204

From: Kyle McMartin <[email protected]>

While building 2.6.32-rc8-git2 for Fedora I noticed the following thinko in
201a15428bd54f83eccec8b7c64a04b8f9431204. This fix looks to be correct?

fs/9p/cache.c: In function '__v9fs_fscache_release_page':
fs/9p/cache.c:346: error: 'vnode' undeclared (first use in this function)
fs/9p/cache.c:346: error: (Each undeclared identifier is reported only once
fs/9p/cache.c:346: error: for each function it appears in.)
make[2]: *** [fs/9p/cache.o] Error 1

Signed-off-by: Kyle McMartin <[email protected]>

---
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index bcc5357..e777961 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -343,7 +343,7 @@ int __v9fs_fscache_release_page(struct page *page, gfp_t gfp)

BUG_ON(!vcookie->fscache);

- return fscache_maybe_release_page(vnode->cache, page, gfp);
+ return fscache_maybe_release_page(vcookie->fscache, page, gfp);
}

void __v9fs_fscache_invalidate_page(struct page *page)

2009-12-01 10:50:10

by David Howells

Subject: Re: [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204

Kyle McMartin <[email protected]> wrote:

> fs/9p/cache.c: In function '__v9fs_fscache_release_page':
> fs/9p/cache.c:346: error: 'vnode' undeclared (first use in this function)
> fs/9p/cache.c:346: error: (Each undeclared identifier is reported only once
> fs/9p/cache.c:346: error: for each function it appears in.)

Seems I didn't turn on all the 9P options I needed :-(

David