2011-05-07 18:57:22

by Nicolas Kaiser

Subject: [PATCH] thp: unbalanced parenthesis

Signed-off-by: Nicolas Kaiser <[email protected]>
---
Untested.

include/asm-generic/pgtable.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index b4bfe33..b80daee 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
pmd_t pmd = *pmdp;
pmd_clear(mm, address, pmdp);
return pmd;
-})
+}
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
#endif

--
1.7.5.rc3

2011-05-30 11:03:26

by Nicolas Kaiser

Subject: Re: [PATCH] thp: unbalanced parenthesis

Cc'ed Andrea Arcangeli.

* Nicolas Kaiser <[email protected]>:
> Signed-off-by: Nicolas Kaiser <[email protected]>
> ---
> Untested.
>
> include/asm-generic/pgtable.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> index b4bfe33..b80daee 100644
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> pmd_t pmd = *pmdp;
> pmd_clear(mm, address, pmdp);
> return pmd;
> -})
> +}
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> #endif
>

2011-05-30 14:10:37

by Andrea Arcangeli

Subject: Re: [PATCH] thp: unbalanced parenthesis

On Mon, May 30, 2011 at 01:02:09PM +0200, Nicolas Kaiser wrote:
> Cc'ed Andrea Arcangeli.
>
> * Nicolas Kaiser <[email protected]>:
> > Signed-off-by: Nicolas Kaiser <[email protected]>
> > ---
> > Untested.
> >
> > include/asm-generic/pgtable.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> > index b4bfe33..b80daee 100644
> > --- a/include/asm-generic/pgtable.h
> > +++ b/include/asm-generic/pgtable.h
> > @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> > pmd_t pmd = *pmdp;
> > pmd_clear(mm, address, pmdp);
> > return pmd;
> > -})
> > +}
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > #endif

Reviewed-by: Andrea Arcangeli <[email protected]>

All archs supporting THP aren't using that function so it isn't
possible to notice it in any config but it's better to fix it in case
some arch will use it in the future.

Thanks,
Andrea