2012-06-29 13:23:20

by Alexandre Courbot

[permalink] [raw]
Subject: [PATCH] arm: tegra: add Ventana backlight device

Add the backlight device to the Ventana device tree.

Signed-off-by: Alexandre Courbot <[email protected]>
---
arch/arm/boot/dts/tegra20-ventana.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/tegra20-ventana.dts b/arch/arm/boot/dts/tegra20-ventana.dts
index be90544..27616f7 100644
--- a/arch/arm/boot/dts/tegra20-ventana.dts
+++ b/arch/arm/boot/dts/tegra20-ventana.dts
@@ -317,6 +317,27 @@
bus-width = <8>;
};

+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 2 5000000>;
+
+ brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224 240 255>;
+ default-brightness-level = <12>;
+ power-supply = <&backlight_reg>;
+ enable-gpios = <&gpio 28 0>;
+ };
+
+ backlight_reg: fixedregulator@176 {
+ compatible = "regulator-fixed";
+ regulator-name = "backlight_regulator";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ gpio = <&gpio 176 0>;
+ startup-delay-us = <0>;
+ enable-active-high;
+ regulator-boot-off;
+ };
+
sound {
compatible = "nvidia,tegra-audio-wm8903-ventana",
"nvidia,tegra-audio-wm8903";
--
1.7.11.1


2012-06-29 16:06:41

by Stephen Warren

[permalink] [raw]
Subject: Re: [PATCH] arm: tegra: add Ventana backlight device

On 06/29/2012 07:24 AM, Alexandre Courbot wrote:
> Add the backlight device to the Ventana device tree.

As I mentioned downstream, I have a patch to add all the regulators for
Ventana to DT. This patch should be rebased on top of that, since it
adds the backlight regulator node too, but co-locates it with a bunch of
other regulators, so won't merge with this patch.

I hope I'll be able to publish an updated version of the Ventana patch
today.

But aside from that, this patch looks reasonable.

2012-06-30 03:40:55

by Alexandre Courbot

[permalink] [raw]
Subject: Re: [PATCH] arm: tegra: add Ventana backlight device

On Sat 30 Jun 2012 01:06:37 AM JST, Stephen Warren wrote:
> As I mentioned downstream, I have a patch to add all the regulators for
> Ventana to DT. This patch should be rebased on top of that, since it
> adds the backlight regulator node too, but co-locates it with a bunch of
> other regulators, so won't merge with this patch.

Ok, better wait for your patch then. No need to hurry, this depends on
other stuff anyway.

Alex.