2012-08-10 00:02:36

by Jan Engelhardt

Subject: Re: "Inconsistent kallsyms data" error

On Saturday 2012-07-07 23:40, Michal Marek wrote:
>index cd9c6c6..4629038 100644
>--- a/scripts/link-vmlinux.sh
>+++ b/scripts/link-vmlinux.sh
>@@ -210,8 +210,8 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then
> mksysmap ${kallsyms_vmlinux} .tmp_System.map
>
> if ! cmp -s System.map .tmp_System.map; then
>- echo Inconsistent kallsyms data
>- echo echo Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
>+ echo >&2 Inconsistent kallsyms data
>+ echo >&2 echo Try "make KALLSYMS_EXTRA_PASS=1" as a workaround

Hm why is there echo twice in that one line? Seems like an oversight..

2012-08-10 09:59:57

by Michal Marek

Subject: Re: "Inconsistent kallsyms data" error

On Fri, Aug 10, 2012 at 02:02:33AM +0200, Jan Engelhardt wrote:
>
> On Saturday 2012-07-07 23:40, Michal Marek wrote:
> >index cd9c6c6..4629038 100644
> >--- a/scripts/link-vmlinux.sh
> >+++ b/scripts/link-vmlinux.sh
> >@@ -210,8 +210,8 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then
> > mksysmap ${kallsyms_vmlinux} .tmp_System.map
> >
> > if ! cmp -s System.map .tmp_System.map; then
> >- echo Inconsistent kallsyms data
> >- echo echo Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
> >+ echo >&2 Inconsistent kallsyms data
> >+ echo >&2 echo Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
>
> Hm why is there echo twice in that one line? Seems like an oversight..

Good catch.

>From 367e43c50d7f7c3b0cec17f4d855a96f47f5e17b Mon Sep 17 00:00:00 2001
From: Michal Marek <[email protected]>
Date: Fri, 10 Aug 2012 11:55:11 +0200
Subject: [PATCH] link-vmlinux.sh: Fix stray "echo" in error message

Reported-by: Jan Engelhardt <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
---
scripts/link-vmlinux.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 4629038..4235a63 100644
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -211,7 +211,7 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then

if ! cmp -s System.map .tmp_System.map; then
echo >&2 Inconsistent kallsyms data
- echo >&2 echo Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
+ echo >&2 Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
cleanup
exit 1
fi