2012-10-02 08:21:16

by Ohad Ben Cohen

[permalink] [raw]
Subject: Re: [PATCH] remoteproc: Fix use of format specifyer

On Fri, Sep 28, 2012 at 5:35 PM, Emil Goode <[email protected]> wrote:
> The dma_addr_t type can be eigher u32 or u64 depending on
> the configuration. We should use a format specifyer for the
> larges type and explicitly cast to it.
>
> Sparse warnings:
> drivers/remoteproc/remoteproc_core.c:234:2: warning:
> format ?%x? expects argument of type ?unsigned int?,
> but argument 6 has type ?dma_addr_t? [-Wformat]
>
> drivers/remoteproc/remoteproc_core.c:596:2: warning:
> format ?%x? expects argument of type ?unsigned int?,
> but argument 5 has type ?dma_addr_t? [-Wformat]
>
> drivers/remoteproc/remoteproc_core.c:634:3:
> warning: format ?%x? expects argument of type ?unsigned int?,
> but argument 5 has type ?dma_addr_t? [-Wformat]
>
> Signed-off-by: Emil Goode <[email protected]>

Applied (after fixing some commit log typos), thanks.