2008-11-28 15:36:55

by Bastien Nocera

[permalink] [raw]
Subject: [PATCH] Move PIN codes to an external database

Heya,

This is a patch to move the PIN quirks to an external tab-separated text
file. The parser is very simple and naive, but does the job for all the
devices I tested.

string_to_type() should probably be using an array instead of the
current code, and I've managed to move the current quirks to the
external file without a problem.

When this gets in, I'll work on moving all the quirks filed as bugs
against the wizard[1] into bluez-gnome proper.

Cheers

[1]: http://bugzilla.gnome.org/buglist.cgi?product=bluez-gnome&bug_status=NEW&bug_status=REOPENED&bug_status=ASSIGNED&bug_status=UNCONFIRMED&component=wizard


Attachments:
0001-Move-the-PIN-quirks-to-an-external-database.patch (5.72 kB)

2008-11-28 17:14:35

by Stefan Seyfried

[permalink] [raw]
Subject: Re: [PATCH] Move PIN codes to an external database

On Fri, Nov 28, 2008 at 04:50:46PM +0100, Marcel Holtmann wrote:
> Hi Bastien,
>
> > This is a patch to move the PIN quirks to an external tab-separated text
> > file. The parser is very simple and naive, but does the job for all the
> > devices I tested.
> >
> > string_to_type() should probably be using an array instead of the
> > current code, and I've managed to move the current quirks to the
> > external file without a problem.
> >
> > When this gets in, I'll work on moving all the quirks filed as bugs
> > against the wizard[1] into bluez-gnome proper.
>
> should we not better store this in GConf?

Hopefully some day Tom will port his kde4 stuff to BlueZ-4, then it will be
nice if we have one global database, not one per project.
--
Stefan Seyfried
R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N?rnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG N?rnberg)

2008-11-28 16:15:59

by Bastien Nocera

[permalink] [raw]
Subject: Re: [PATCH] Move PIN codes to an external database

On Fri, 2008-11-28 at 16:50 +0100, Marcel Holtmann wrote:
> Hi Bastien,
>
> > This is a patch to move the PIN quirks to an external tab-separated text
> > file. The parser is very simple and naive, but does the job for all the
> > devices I tested.
> >
> > string_to_type() should probably be using an array instead of the
> > current code, and I've managed to move the current quirks to the
> > external file without a problem.
> >
> > When this gets in, I'll work on moving all the quirks filed as bugs
> > against the wizard[1] into bluez-gnome proper.
>
> should we not better store this in GConf?

GConf is a configuration database. This isn't configuration...

2008-11-28 15:50:46

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Move PIN codes to an external database

Hi Bastien,

> This is a patch to move the PIN quirks to an external tab-separated text
> file. The parser is very simple and naive, but does the job for all the
> devices I tested.
>
> string_to_type() should probably be using an array instead of the
> current code, and I've managed to move the current quirks to the
> external file without a problem.
>
> When this gets in, I'll work on moving all the quirks filed as bugs
> against the wizard[1] into bluez-gnome proper.

should we not better store this in GConf?

Regards

Marcel