2008-11-29 16:39:17

by Bastien Nocera

[permalink] [raw]
Subject: [PATCH] More PIN quirks

This builds on top of the move to a PIN database.

This fixes all but one bug filed against the wizard in the GNOME
bugzilla.

I hope it shows that the PIN database is workable.

Cheers


Attachments:
0001-Add-other-audio-devices.patch (2.66 kB)
0002-Handle-printers-in-the-wizard.patch (1.12 kB)
0003-Add-quirks-for-loads-of-GPS-devices.patch (1.32 kB)
0004-Add-more-PIN-quirks.patch (1.53 kB)
0001-Add-icon-for-other-audio-device.patch (658.00 B)
Download all attachments

2008-11-29 17:32:05

by Jelle de Jong

[permalink] [raw]
Subject: Re: [PATCH] More PIN quirks

Bastien Nocera wrote:
> This builds on top of the move to a PIN database.
>
> This fixes all but one bug filed against the wizard in the GNOME
> bugzilla.
>
> I hope it shows that the PIN database is workable.
>
> Cheers
>

Thank you Bastien for your hard work!

I have a few questions about these kind of patches, would it not be
easer to maintainable and more usefull to add this kind of information
separate from gnome related packages, and move them to a desktop
independent configuration?

Of course there is nothing wrong with using gnome bugreports or using
gnome applications with the data. However I have seen a lot of patches
that apply to the gnome wizard application and the commandline tools or
kde tools do not use this information, but it would really like the same
functionality in the command line tools so it does work platform
independent.

I know there is not much priority on fixing a commandline tool but, it
can be smart to move device specific info into a general system that all
user frontend systems can use. This will make it a lot easer of other
developers to create new frontends that do not need to reverse engineer
the gnome apps and create duplicated hard to maintain code....

Does this make any sense? Or is there just no time or do we not care
about other users then gnome?

Best regards,

Jelle