Heya,
Patch is necessary to make the Wacom Bluetooth driver I posted to
linux-input work as expected. I've tested this successfully with my
tablet[1].
Cheers
[1]: For Marcel, if you want a funky new device, look for CTE-630BT:
http://www.wacom-europe.com/index2.asp?pid=163&lang=en
http://www.wacom-shop.net/cgi-bin/wacom.storefront/49c0379700eeee24273f4ddcef2606ba/Product/View/CTE&2D630BT3
On Sat, 2009-03-14 at 07:09 +0100, Marcel Holtmann wrote:
> Hi Bastien,
>
> > Patch is necessary to make the Wacom Bluetooth driver I posted to
> > linux-input work as expected. I've tested this successfully with my
> > tablet[1].
>
> this maybe sound like a nit-pick, but please add an extra empty line
> between the if-statement and the ioctl.
>
> + write(sk, buf, sizeof(buf));
> + }
> err = ioctl_connadd(req);
>
> The original code had one and so should have the new one with this extra
> quirk.
OK.
> Also can we please check at least the return value of write().
>
> + write(sk, buf, sizeof(buf));
>
> Check the return value and at minimum have an error message printed.
The writes actually fail, from what I've seen, but it works... I'll try
to get some details about what fails.
Hi Bastien,
> Patch is necessary to make the Wacom Bluetooth driver I posted to
> linux-input work as expected. I've tested this successfully with my
> tablet[1].
this maybe sound like a nit-pick, but please add an extra empty line
between the if-statement and the ioctl.
+ write(sk, buf, sizeof(buf));
+ }
err = ioctl_connadd(req);
The original code had one and so should have the new one with this extra
quirk.
Also can we please check at least the return value of write().
+ write(sk, buf, sizeof(buf));
Check the return value and at minimum have an error message printed.
Regards
Marcel