2009-09-22 21:31:47

by Claudio Takahasi

Subject: [PATCH] Fix extra PropertyChanged signal sent after DeviceRemoved

Hi,

for paired devices, there is an extra PropertyChanged signal sent
after DeviceRemoved:

signal sender=:1.78 -> dest=(null destination) serial=145
path=/org/bluez/24533/hci0; interface=org.bluez.Adapter;
member=PropertyChanged
string "Devices"
variant array [
]
signal sender=:1.78 -> dest=(null destination) serial=146
path=/org/bluez/24533/hci0; interface=org.bluez.Adapter;
member=DeviceRemoved
object path "/org/bluez/24533/hci0/dev_00_1F_00_CE_BE_AF"
signal sender=:1.78 -> dest=(null destination) serial=147
path=/org/bluez/24533/hci0/dev_00_1F_00_CE_BE_AF;
interface=org.bluez.Device; member=PropertyChanged
string "Paired"
variant boolean false


The patch to fix this issue is in my branch devel:

git://git.infradead.org/users/cktakahasi/bluez.git devel

I removed "textfile_caseget()" call before call "textfile_casedel()",
let me know if you wanna keep this check, I can revert this minor
change.

Br,
Claudio

--
--
Claudio Takahasi
Instituto Nokia de Tecnologia
Recife - Pernambuco - Brasil
+55 81 30879999

2009-09-22 21:54:30

by Marcel Holtmann

Subject: Re: [PATCH] Fix extra PropertyChanged signal sent after DeviceRemoved

Hi Claudio,

> for paired devices, there is an extra PropertyChanged signal sent
> after DeviceRemoved:
>
> signal sender=:1.78 -> dest=(null destination) serial=145
> path=/org/bluez/24533/hci0; interface=org.bluez.Adapter;
> member=PropertyChanged
> string "Devices"
> variant array [
> ]
> signal sender=:1.78 -> dest=(null destination) serial=146
> path=/org/bluez/24533/hci0; interface=org.bluez.Adapter;
> member=DeviceRemoved
> object path "/org/bluez/24533/hci0/dev_00_1F_00_CE_BE_AF"
> signal sender=:1.78 -> dest=(null destination) serial=147
> path=/org/bluez/24533/hci0/dev_00_1F_00_CE_BE_AF;
> interface=org.bluez.Device; member=PropertyChanged
> string "Paired"
> variant boolean false
>
>
> The patch to fix this issue is in my branch devel:
>
> git://git.infradead.org/users/cktakahasi/bluez.git devel

patch has been applied. Thanks.

> I removed "textfile_caseget()" call before call "textfile_casedel()",
> let me know if you wanna keep this check, I can revert this minor
> change.

I can't remember why it is there. Johan might know and we can revert it
then later if I missed the reason.

Regards

Marcel