Hi,
hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
don't know what Icon_10 was, perhaps an older name?
Eg, from an SDP probe of a mouse:
aid 0x000d (IconURL)
< < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
Anyway, patch below fixes it up. Sorry, I don't have a git here can't
provide a gitpatch atm
regards,
iain
--- parser/sdp.h.orig 2009-11-30 19:29:35.000000000 +0000
+++ parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
--- parser/sdp.c.orig 2009-11-30 19:29:31.000000000 +0000
+++ parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sd
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
On Mon, 30 Nov 2009, Iain Hibbert wrote:
> hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> don't know what Icon_10 was, perhaps an older name?
>
> Eg, from an SDP probe of a mouse:
>
> aid 0x000d (IconURL)
> < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
Reposting because there was no response to this, patch is attached..
See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
Attribute" sections in the core specification for reference..
(they sometimes call it AdditionalProtocolDescriptorLists and that is more
accurate as more than one protocol descriptor list may be included)
regards,
iain
Hi Iain,
> > > > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > > > don't know what Icon_10 was, perhaps an older name?
> > > > > > >
> > > > > > > Eg, from an SDP probe of a mouse:
> > > > > > >
> > > > > > > aid 0x000d (IconURL)
> > > > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > > > >
> > > > > > Reposting because there was no response to this, patch is attached..
> > > > > >
> > > > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > > > Attribute" sections in the core specification for reference..
> > > > > >
> > > > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > > > accurate as more than one protocol descriptor list may be included)
> > > > >
> > > > > posting this simple (and easily verified) patch for hcidump for the third
> > > > > time..
> > > >
> > > > sorry for having missed it. For some reason it got sorted away. Can you
> > > > create a proper patch with git format-patch. That makes it way easier
> > > > for me to apply them.
> > >
> > > I am not a git user but perhaps this is correct?
> >
> > almost, but you need to edit your .gitconfig to create a proper author
> > name and more specific author email entry.
>
> Perhaps this is finally correct, but you discourage contributions by being
> so restrictive in accepting submissions. Also, you really do need a bug
> tracker.
patch has been applied. Thanks.
And if I am not restrictive with the patch submission, then I am always
going to clean up after them. Not really something I plan to do.
Regards
Marcel
On Wed, 17 Feb 2010, Marcel Holtmann wrote:
> Hi Iain,
>
> > > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > > don't know what Icon_10 was, perhaps an older name?
> > > > > >
> > > > > > Eg, from an SDP probe of a mouse:
> > > > > >
> > > > > > aid 0x000d (IconURL)
> > > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > > >
> > > > > Reposting because there was no response to this, patch is attached..
> > > > >
> > > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > > Attribute" sections in the core specification for reference..
> > > > >
> > > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > > accurate as more than one protocol descriptor list may be included)
> > > >
> > > > posting this simple (and easily verified) patch for hcidump for the third
> > > > time..
> > >
> > > sorry for having missed it. For some reason it got sorted away. Can you
> > > create a proper patch with git format-patch. That makes it way easier
> > > for me to apply them.
> >
> > I am not a git user but perhaps this is correct?
>
> almost, but you need to edit your .gitconfig to create a proper author
> name and more specific author email entry.
Perhaps this is finally correct, but you discourage contributions by being
so restrictive in accepting submissions. Also, you really do need a bug
tracker.
regards,
iain
Hi Iain,
> > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > don't know what Icon_10 was, perhaps an older name?
> > > > >
> > > > > Eg, from an SDP probe of a mouse:
> > > > >
> > > > > aid 0x000d (IconURL)
> > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > >
> > > > Reposting because there was no response to this, patch is attached..
> > > >
> > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > Attribute" sections in the core specification for reference..
> > > >
> > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > accurate as more than one protocol descriptor list may be included)
> > >
> > > posting this simple (and easily verified) patch for hcidump for the third
> > > time..
> >
> > sorry for having missed it. For some reason it got sorted away. Can you
> > create a proper patch with git format-patch. That makes it way easier
> > for me to apply them.
>
> I am not a git user but perhaps this is correct?
almost, but you need to edit your .gitconfig to create a proper author
name and more specific author email entry.
Regards
Marcel
On Tue, 16 Feb 2010, Marcel Holtmann wrote:
> > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > don't know what Icon_10 was, perhaps an older name?
> > > >
> > > > Eg, from an SDP probe of a mouse:
> > > >
> > > > aid 0x000d (IconURL)
> > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > >
> > > Reposting because there was no response to this, patch is attached..
> > >
> > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > Attribute" sections in the core specification for reference..
> > >
> > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > accurate as more than one protocol descriptor list may be included)
> >
> > posting this simple (and easily verified) patch for hcidump for the third
> > time..
>
> sorry for having missed it. For some reason it got sorted away. Can you
> create a proper patch with git format-patch. That makes it way easier
> for me to apply them.
I am not a git user but perhaps this is correct?
regards,
iain
Hi Iain,
> > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > don't know what Icon_10 was, perhaps an older name?
> > >
> > > Eg, from an SDP probe of a mouse:
> > >
> > > aid 0x000d (IconURL)
> > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> >
> > Reposting because there was no response to this, patch is attached..
> >
> > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > Attribute" sections in the core specification for reference..
> >
> > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > accurate as more than one protocol descriptor list may be included)
>
> posting this simple (and easily verified) patch for hcidump for the third
> time..
sorry for having missed it. For some reason it got sorted away. Can you
create a proper patch with git format-patch. That makes it way easier
for me to apply them.
Regards
Marcel
On Tue, 19 Jan 2010, Iain Hibbert wrote:
> On Mon, 30 Nov 2009, Iain Hibbert wrote:
>
> > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > don't know what Icon_10 was, perhaps an older name?
> >
> > Eg, from an SDP probe of a mouse:
> >
> > aid 0x000d (IconURL)
> > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
>
> Reposting because there was no response to this, patch is attached..
>
> See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> Attribute" sections in the core specification for reference..
>
> (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> accurate as more than one protocol descriptor list may be included)
posting this simple (and easily verified) patch for hcidump for the third
time..
regards,
iain