2010-10-30 14:26:31

by Kulikov Vasiliy

Subject: [PATCH] bluetooth: hidp: fix information leak to userland

Structure hidp_conninfo is copied to userland with version, product,
vendor and name fields unitialized if both session->input and session->hid
are NULL. It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
Compile tested.

net/bluetooth/hidp/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index c0ee8b3..29544c2 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -107,6 +107,7 @@ static void __hidp_unlink_session(struct hidp_session *session)

static void __hidp_copy_session(struct hidp_session *session, struct hidp_conninfo *ci)
{
+ memset(ci, 0, sizeof(*ci));
bacpy(&ci->bdaddr, &session->bdaddr);

ci->flags = session->flags;
@@ -115,7 +116,6 @@ static void __hidp_copy_session(struct hidp_session *session, struct hidp_connin
ci->vendor = 0x0000;
ci->product = 0x0000;
ci->version = 0x0000;
- memset(ci->name, 0, 128);

if (session->input) {
ci->vendor = session->input->id.vendor;
--
1.7.0.4

2010-11-03 18:37:17

by Gustavo Padovan

Subject: Re: [PATCH] bluetooth: hidp: fix information leak to userland

* Marcel Holtmann <[email protected]> [2010-11-02 16:36:29 +0100]:

> Hi Vasiliy,
>
> > Structure hidp_conninfo is copied to userland with version, product,
> > vendor and name fields unitialized if both session->input and session->hid
> > are NULL. It leads to leaking of contents of kernel stack memory.
> >
> > Signed-off-by: Vasiliy Kulikov <[email protected]>
>
> Acked-by: Marcel Holtmann <[email protected]>

Applied, thanks.

--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi

2010-11-02 15:36:29

by Marcel Holtmann

Subject: Re: [PATCH] bluetooth: hidp: fix information leak to userland

Hi Vasiliy,

> Structure hidp_conninfo is copied to userland with version, product,
> vendor and name fields unitialized if both session->input and session->hid
> are NULL. It leads to leaking of contents of kernel stack memory.
>
> Signed-off-by: Vasiliy Kulikov <[email protected]>

Acked-by: Marcel Holtmann <[email protected]>

Regards

Marcel