2012-01-11 15:03:42

by Jaganath Kanakkassery

Subject: [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization

Transfer is registered with id as cid, but authorize method
is called with id as pointer to obex session structure
---
src/manager.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/manager.c b/src/manager.c
index 846f8a0..87010c4 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -539,7 +539,7 @@ int manager_request_authorization(struct obex_session *os, int32_t time,
if (err < 0)
return err;

- path = g_strdup_printf("/transfer%u", GPOINTER_TO_UINT(os));
+ path = g_strdup_printf("/transfer%u", os->id);

msg = dbus_message_new_method_call(agent->bus_name, agent->path,
"org.openobex.Agent", "Authorize");
--
1.7.1

2012-01-11 15:08:27

by Johan Hedberg

Subject: Re: [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization

Hi Jaganath,

On Wed, Jan 11, 2012, Jaganath Kanakkassery wrote:
> Transfer is registered with id as cid, but authorize method
> is called with id as pointer to obex session structure
> ---
> src/manager.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Both patches have been applied. Thanks.

Johan

2012-01-11 14:45:10

by Johan Hedberg

Subject: Re: [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization

Hi Jaganath,

On Wed, Jan 11, 2012, [email protected] wrote:
> From: jaganath.k <[email protected]>
>
> Transfer is registered with id as cid, but authorize method
> is called with id as pointer to obex session structure
> ---
> src/manager.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Both of these patches look fine to me, but you need to fix your git
author name. Once you've done that please resend the patches.

I also noticed that I've by mistake already applied another patch from
you in December with the same bogus author name, so you'll end up
getting your own entry in our infamous .mailmap file.

Johan