2014-11-10 09:10:00

by Andrei Emeltchenko

[permalink] [raw]
Subject: [PATCH] android/gatt: Fix incorrect attribute check

From: Andrei Emeltchenko <[email protected]>

---
android/gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 2fad5ee..086bb94 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -4311,7 +4311,7 @@ static void handle_server_add_included_service(const void *buf, uint16_t len)
}

include = gatt_db_get_attribute(gatt_db, cmd->included_handle);
- if (!service) {
+ if (!include) {
status = HAL_STATUS_FAILED;
goto failed;
}
--
1.9.1



2014-11-10 19:52:28

by Szymon Janc

[permalink] [raw]
Subject: Re: [PATCH] android/gatt: Fix incorrect attribute check

Hi Andrei,

On Monday 10 of November 2014 11:10:00 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 2fad5ee..086bb94 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -4311,7 +4311,7 @@ static void handle_server_add_included_service(const
> void *buf, uint16_t len) }
>
> include = gatt_db_get_attribute(gatt_db, cmd->included_handle);
> - if (!service) {
> + if (!include) {
> status = HAL_STATUS_FAILED;
> goto failed;
> }

Pushed. Thanks.

--
BR
Szymon Janc