2014-12-05 09:48:27

by Andrei Emeltchenko

Subject: [RFC] monitor: Fix RFCOMM parity type mask

From: Andrei Emeltchenko <[email protected]>

---
monitor/rfcomm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
index fe3afb7..71a2792 100644
--- a/monitor/rfcomm.c
+++ b/monitor/rfcomm.c
@@ -67,7 +67,7 @@ static char *cr_str[] = {
#define GET_RPN_DB(parity) (parity & 0x03)
#define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
#define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
-#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
+#define GET_RPN_PTYPE(parity) ((parity & 0x10) >> 4)
#define GET_RPN_XIN(io) (io & 0x01)
#define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
#define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
--
1.9.1

2014-12-05 10:42:03

by Gowtham Anandha Babu

Subject: RE: [RFC] monitor: Fix RFCOMM parity type mask

Hi Andrei,

> -----Original Message-----
> From: [email protected] [mailto:linux-bluetooth-
> [email protected]] On Behalf Of Andrei Emeltchenko
> Sent: Friday, December 05, 2014 3:18 PM
> To: [email protected]
> Subject: [RFC] monitor: Fix RFCOMM parity type mask
>
> From: Andrei Emeltchenko <[email protected]>
>
> ---
> monitor/rfcomm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c index fe3afb7..71a2792
> 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -67,7 +67,7 @@ static char *cr_str[] = {
> #define GET_RPN_DB(parity) (parity & 0x03)
> #define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
> #define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
> -#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
> +#define GET_RPN_PTYPE(parity) ((parity & 0x10) >> 4)
> #define GET_RPN_XIN(io) (io & 0x01)
> #define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
> #define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to [email protected] More majordomo
> info at http://vger.kernel.org/majordomo-info.html


I missed it during the implementation. Anyway, the parity type bits are in
BIT5 and BIT6 as per the specification.
So it will be 0x30 instead of 0x10.

Regards,
Gowtham Anandha Babu