2016-10-18 15:01:18

by Wei Yongjun

Subject: [PATCH -next] Bluetooth: hci_bcsp: Use setup_timer instead of init_timer and data fields

From: Wei Yongjun <[email protected]>

Use setup_timer function instead of initializing timer with the function
and data fields

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/bluetooth/hci_bcsp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index a2c921f..910ec96 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -733,9 +733,7 @@ static int bcsp_open(struct hci_uart *hu)
skb_queue_head_init(&bcsp->rel);
skb_queue_head_init(&bcsp->unrel);

- init_timer(&bcsp->tbcsp);
- bcsp->tbcsp.function = bcsp_timed_event;
- bcsp->tbcsp.data = (u_long)hu;
+ setup_timer(&bcsp->tbcsp, bcsp_timed_event, (u_long)hu);

bcsp->rx_state = BCSP_W4_PKT_DELIMITER;

2016-10-18 15:05:46

by Marcel Holtmann

Subject: Re: [PATCH -next] Bluetooth: hci_bcsp: Use setup_timer instead of init_timer and data fields

Hi Wei,

> Use setup_timer function instead of initializing timer with the function
> and data fields
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/bluetooth/hci_bcsp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

didn't I just apply this patch?

Regards

Marcel