2018-05-14 21:38:47

by Vaibhav Murkute

Subject: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces

checkpatch.pl shows a warning for these unnecessary curly braces.
so just removed those curly braces.

Signed-off-by: Vaibhav Murkute <[email protected]>
---
drivers/bluetooth/hci_serdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
index e0e6461..a0e9398 100644
--- a/drivers/bluetooth/hci_serdev.c
+++ b/drivers/bluetooth/hci_serdev.c
@@ -204,9 +204,8 @@ static int hci_uart_setup(struct hci_dev *hdev)
return 0;
}

- if (skb->len != sizeof(*ver)) {
+ if (skb->len != sizeof(*ver))
bt_dev_err(hdev, "Event length mismatch for version info");
- }

kfree_skb(skb);
return 0;
--
2.7.4

2018-05-22 07:25:11

by Marcel Holtmann

Subject: Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces

Hi Vaibhav,

> checkpatch.pl shows a warning for these unnecessary curly braces.
> so just removed those curly braces.
>
> Signed-off-by: Vaibhav Murkute <[email protected]>
> ---
> drivers/bluetooth/hci_serdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2018-05-13 22:49:54

by Andy Shevchenko

Subject: Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces

On Sat, May 12, 2018 at 1:12 AM, Vaibhav Murkute
<[email protected]> wrote:
> checkpatch.pl shows a warning for these unnecessary curly braces.
> so just removed those curly braces.
>
> Signed-off-by: Vaibhav Murkute <[email protected]>
> ---
> drivers/bluetooth/hci_serdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
> index e0e6461..137c314 100644
> --- a/drivers/bluetooth/hci_serdev.c
> +++ b/drivers/bluetooth/hci_serdev.c
> @@ -204,9 +204,9 @@ static int hci_uart_setup(struct hci_dev *hdev)
> return 0;
> }
>
> - if (skb->len != sizeof(*ver)) {
> + if (skb->len != sizeof(*ver))
> bt_dev_err(hdev, "Event length mismatch for version info");
> - }
> +
>
> kfree_skb(skb);
> return 0;

Why did you add redundant empty line(s) instead?


--
With Best Regards,
Andy Shevchenko