2009-01-23 14:09:46

by Daniele Venzano

Subject: Re: [PATCH] Fix unused variable warning in rfcomm

Sorry, shouldn't have missed that.

The following patch fixes a warning generated when compiling rfcomm.c
without CONFIG_BT_RFCOMM_DEBUG.
The warning was:
net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_ioctl':
net/bluetooth/rfcomm/sock.c:795: warning: unused variable 'sk'

Patch is against 2.6.28.1

Signed-off-by: Daniele Venzano <[email protected]>

--- a/net/bluetooth/rfcomm/sock.c 2009-01-23 10:30:34.000000000 +0100
+++ b/net/bluetooth/rfcomm/sock.c 2009-01-23 15:09:00.000000000 +0100
@@ -792,7 +792,9 @@ static int rfcomm_sock_getsockopt(struct

static int rfcomm_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
{
+#if defined(CONFIG_BT_RFCOMM_DEBUG) || defined(CONFIG_BT_RFCOMM_TTY)
struct sock *sk = sock->sk;
+#endif
int err;

BT_DBG("sk %p cmd %x arg %lx", sk, cmd, arg);

2009-01-23 14:22:09

by Marcel Holtmann

Subject: Re: [PATCH] Fix unused variable warning in rfcomm

Hi guys,

> Sorry, shouldn't have missed that.
>
> The following patch fixes a warning generated when compiling rfcomm.c
> without CONFIG_BT_RFCOMM_DEBUG.
> The warning was:
> net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_ioctl':
> net/bluetooth/rfcomm/sock.c:795: warning: unused variable 'sk'

this has been fixed upstream already. So why does this come up again?

Regards

Marcel