2009-07-01 11:15:56

by Filippo Giunchedi

[permalink] [raw]
Subject: [PATCH] gstreamer a2dp as marginal plugin

This patch avoids taking over the default output sink by registering a2dp as
RANK_MARGINAL.
I'm not sure this is desiderable in general but at least autoaudiosink does the
right thing and selects ALSA/OSS which are RANK_PRIMARY.

Filippo Giunchedi (1):
Register the a2dp gst sink as marginal

audio/gsta2dpsink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)



2009-07-03 14:47:23

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] gstreamer a2dp as marginal plugin

Hi Filippo,

On Wed, Jul 01, 2009, Filippo Giunchedi wrote:
> This patch avoids taking over the default output sink by registering a2dp as
> RANK_MARGINAL.
> I'm not sure this is desiderable in general but at least autoaudiosink does the
> right thing and selects ALSA/OSS which are RANK_PRIMARY.
>
> Filippo Giunchedi (1):
> Register the a2dp gst sink as marginal
>
> audio/gsta2dpsink.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

This one has been pushed upstream too.

Johan

2009-07-01 11:15:57

by Filippo Giunchedi

[permalink] [raw]
Subject: [PATCH] Register the a2dp gst sink as marginal

Avoid taking over as default gst sink by registering as GST_RANK_MARGINAL
---
audio/gsta2dpsink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/gsta2dpsink.c b/audio/gsta2dpsink.c
index b6df119..0753f38 100644
--- a/audio/gsta2dpsink.c
+++ b/audio/gsta2dpsink.c
@@ -698,6 +698,6 @@ static void gst_a2dp_sink_init(GstA2dpSink *self,
gboolean gst_a2dp_sink_plugin_init(GstPlugin *plugin)
{
return gst_element_register(plugin, "a2dpsink",
- GST_RANK_PRIMARY, GST_TYPE_A2DP_SINK);
+ GST_RANK_MARGINAL, GST_TYPE_A2DP_SINK);
}

--
1.6.3.3