This patch works around one problem with my Acer Bluetooth Optical
Rechargeable Mouse where the cursor gets stuck at screen's upper-left corner.
Even my notebook's touchpad is not able to move cursor when the bluetooth
mouse is connected to my Acer Ferrari 4005 notebook. Using input session
instead of hid session solves this problem although the cursor still moves a
little sluggishly with the bluetooth mouse, cursor moves correctly using the
touchpad. My bluetooth mouse used to work well (no sluggish) until kernel
2.6.21, since then the problems are getting worse with each kernel release (it
got sluggish in 2.6.22 and this this upper-left corner problem appeared in
2.6.28 or 2.6.27).
Signed-off-by: Lamarque V. Souza <[email protected]>
---
diff -Nru --show-c-function linux-2.6.30.1-orig/net/bluetooth/hidp/core.c
linux-2.6.30.1-lvs/net/bluetooth/hidp/core.c
--- linux-2.6.30.1-orig/net/bluetooth/hidp/core.c 2009-07-16
23:53:04.697925121 -0300
+++ linux-2.6.30.1-lvs/net/bluetooth/hidp/core.c 2009-07-17 02:35:03.969927384
-0300
@@ -73,6 +73,43 @@ static unsigned char hidp_keycode[256] =
static unsigned char hidp_mkeyspat[] = { 0x01, 0x01, 0x01, 0x01, 0x01, 0x01
};
+/* HIDP device quirks */
+enum {
+ HIDP_QUIRK_USE_INPUT_SESSION
+};
+
+struct quirk_id {
+ __u16 vendor;
+ __u16 product;
+ unsigned long quirks;
+};
+
+static const struct quirk_id hidp_quirks[] = {
+ {
+ /* Lamarque: Acer Bluetooth Optical Rechargeable Mouse
+ * does not work properly with hid session since 2.6.27. */
+ .vendor = 0x0458,
+ .product = 0x0058,
+ .quirks = 1 << HIDP_QUIRK_USE_INPUT_SESSION
+ },
+
+ { /* end: all zeroes */ }
+};
+
+static int quirk_test_bit(__u16 vendor, __u16 product, int quirk)
+{
+ const struct quirk_id *q = &hidp_quirks[0];
+
+ while (q->vendor != vendor && q->product != product &&
+ q->vendor && q->product)
+ q++;
+
+ if (q->vendor == vendor && q->product == product)
+ return test_bit(quirk, &q->quirks);
+
+ return 0;
+}
+
static struct hidp_session *__hidp_get_session(bdaddr_t *bdaddr)
{
struct hidp_session *session;
@@ -832,7 +869,9 @@ int hidp_add_connection(struct hidp_conn
session->flags = req->flags & (1 << HIDP_BLUETOOTH_VENDOR_ID);
session->idle_to = req->idle_to;
- if (req->rd_size > 0) {
+ if (req->rd_size > 0 &&
+ !quirk_test_bit(req->vendor, req->product,
+ HIDP_QUIRK_USE_INPUT_SESSION)) {
err = hidp_setup_hid(session, req);
if (err && err != -ENODEV)
goto err_skb;